Closed dchen97 closed 1 year ago
juliafalarini
commented
1 year ago In progress. I have updated the mocks and created a second version of the Research Plan and Prototype, to test some improvements. One Outreachy contributor has already submitted a report.
juliafalarini
commented
1 year ago Working on hi-fi mocks
seanlip
commented
1 year ago @jikim322 @ConorMack @rfinch11 Could you please take a look at https://www.figma.com/file/YWe7SqfUVjxlJLKTUn0UZa/Project-2?type=design&node-id=6050-159194&mode=design&t=rX2OGatHaHf4LLVY-0 and leave comments / sign-off as needed, so that this can move to the development stage? Thank you!
jikim322
commented
1 year ago @juliafalarini Added a couple of comments for minor text edits. Once those are made, looks good for UXW!
ghost
commented
1 year ago Hi all,
I also added some comments. Thank you!
On Mon, Jul 10, 2023 at 7:59 PM jikim322 @.***> wrote:
@juliafalarini https://github.com/juliafalarini Added a couple of comments for minor text edits. Once those are made, looks good for UXW!
— Reply to this email directly, view it on GitHub https://github.com/oppia/design-team/issues/69#issuecomment-1629937485, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5HFQLZWZYJAPE6OFLW5V5DXPSQOLANCNFSM6AAAAAAWMTAXFE . You are receiving this because you were mentioned.Message ID: @.***>
rfinch11
commented
1 year ago I've also added several comments, but I'd like to see resolutions before signing off from UXD
juliafalarini
commented
1 year ago Hi @rfinch11 @roxanashirazi @jikim322 and @seanlip. Thanks for your feedback! I've addressed/replied your comments!
Also, I'm having an issue with the body text style. I'm using the style from the Design Guide, but when I click to view the text style, the parameters are different (e.g. instead of a line height of 120% it's 20pt). I'm not allowed to change it, and when I click on "Go to style definition to edit", I'm redirected to the Design Guide file, where the parameters are correct, so there's nothing I can do. Does anyone have any idea how I can solve this problem?
rfinch11
commented
1 year ago @juliafalarini just to make sure I'm looking at the same thing, is this the file you're referencing? https://www.figma.com/file/nrQrOxSxSg1oabuVE6XJpa/Oppia-Design-Guide?node-id=430%3A2581&t=BjKbQWldwlIOrk44-0
When I look at the typography section of the Design System, I see the correct parameters (see screenshot below)
juliafalarini
commented
1 year ago Yes, this is the file I'm referencing, and it looks correct to me too. It just doesn't look correct in my file, even though it's referenced from the Design Guide file. @rfinch11
rfinch11
commented
1 year ago Got it. Very strange that it got corrupted in some way in your version. Want to try setting up a new file and bringing in the design system again to see if the same issue occurs?
juliafalarini
commented
1 year ago @rfinch11 yes, the same issue occurs in a new file :/
juliafalarini
commented
1 year ago Hi @rfinch11 @roxanashirazi @jikim322, did you get a chance to check my replies to your comments? we should finalize it asap so it can be moved to development. Thanks!
jikim322
commented
1 year ago @juliafalarini I think the only outstanding UXW item was the exclamation point in the CTA "Got it!" I made comments to remove/replace exclamation points from tooltip text and to keep in the CTA. I think once that's updated, it'll be good to go for UXW
rfinch11
commented
1 year ago Approved!
seanlip
commented
1 year ago The changes in this issue have been filed as separate issues on the GitHub developer issue tracker:
https://docs.google.com/document/d/1r91ypya5HasdGsuLcuzt_utKik6xpIVe9koYGynl6kg/edit
Includes raising discoverability of language picker
DESIGN APPROVAL CHECKLIST -- DO NOT EDIT.
For a design project to be completed, it needs approval from UXD, UXW and PM. Please tag the following reviewers when your project is ready (it's enough to have one signoff from each of UXD, UXW and PM):