search

oppia / foundation-website

Repository for developing the new Oppia Foundation website.
Apache License 2.0
6 stars 32 forks source link

Fix #117: Introduce workaround to prevent md-tab from shrinking md-tab-item to 0px #118

Closed hoangviet1993 closed 4 years ago

hoangviet1993 commented 4 years ago

Steps of reproducing issue: Method 1: Reloading the page a bunch of times until bug presents itself. Method 2: Sometimes the buggy tab will appear on first page load as well. Screenshot of visual bug: Screen Shot 2019-07-12 at 10 23 33 AM This issue is a known issue from md-tab: https://github.com/angular/material/issues/4237 I simply put in the workaround suggested by one of the commenter. Changes in this PR are live at: https://oppia-foundation-test-server-1.appspot.com/

codecov-io commented 4 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         390      390           
=======================================
  Hits          376      376           
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e49011...875a442. Read the comment docs.

hoangviet1993 commented 4 years ago

This is simply a work-around. The original issue has been closed due to AngularJS Material being deprecated. @seanlip, what do you think?