oppia / foundation-website

Repository for developing the new Oppia Foundation website.

Apache License 2.0

6 stars 32 forks source link

Dropdown navbar button and new sidenav links for new About pages #120

Closed hoangviet1993 closed 5 years ago

hoangviet1993 commented 5 years ago

This PR implements the dropdown button so as to provide the same hub for linking the two new "About" pages (Oppia and Foundation). Changes in this PR are live at: https://oppia-foundation-test-server-1.appspot.com/

Desktop screenshot:

Screen Shot 2019-07-31 at 3 40 31 PM

Desktop gif: 2019-07-31 16 05 05

Mobile sidenav screenshot: Screen Shot 2019-07-31 at 4 03 05 PM

codecov-io commented 5 years ago

Codecov Report

Merging #120 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         390      390           
=======================================
  Hits          376      376           
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 519df00...ebc259e. Read the comment docs.

hoangviet1993 commented 5 years ago

@rachelwchen and @dchen97 Can you PTAL?

rachelwchen commented 5 years ago

Looks good to me!

dchen97 commented 5 years ago

Thanks Viet! The only note is that in the Mobile view, could you add "About" in front of "The Foundation" and "The Oppia Platform" to better clarify that these links are tied to an "About" page? So instead of saying "The Foundation" or "The Oppia Platform," it can say "About The Foundation" and "About The Oppia Platform."

Otherwise, everything else looks good!

hoangviet1993 commented 5 years ago

Changes are live at https://oppia-foundation-test-server-1.appspot.com/

could you add "About" in front of "The Foundation" and "The Oppia Platform" to better clarify that these links are tied to an "About" page? So instead of saying "The Foundation" or "The Oppia Platform",

Done! Thanks for taking a look!

it can say "About The Foundation" and "About The Oppia Platform."

Screen Shot 2019-08-03 at 8 23 12 PM

hoangviet1993 commented 5 years ago

@rachelwchen @dchen97 Anything else needs to be addressed here?

rachelwchen commented 5 years ago

Looks good to me!