Closed hoangviet1993 closed 5 years ago
@rachelwchen @dchen97 Can you PTAL?
Thanks so much Viet! Just a few notes:
Other than those notes, it looks great to me!
Merging #121 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #121 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 21 21
Lines 390 390
=======================================
Hits 376 376
Misses 14 14
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 631a0a3...14463f4. Read the comment docs.
@dchen97 All done! Thanks
we need to update the links for the buttons on the homepage to now appropriately direct to either this page or the about Oppia page.
@dchen97 This is already done in this PR. Can you visit the test site and take a look at the navbar on desktop and the sidebar on mobile?
Ahh I was speaking more on the highlighted buttons on the homepage, like the one that says "See the Oppia Difference." I think the navbar is fine.
On Thu, Aug 8, 2019, 12:18 PM Viet Tran Quoc Hoang notifications@github.com wrote:
we need to update the links for the buttons on the homepage to now appropriately direct to either this page or the about Oppia page.
This is already done in this PR. Can you visit the test site and take a look at the navbar on desktop and the sidebar on mobile?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/oppia/foundation-website/pull/121?email_source=notifications&email_token=AC32BWZ45YK5FORD7C4QQZTQDRIOFA5CNFSM4IJ3BXSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD34J6ZI#issuecomment-519610213, or mute the thread https://github.com/notifications/unsubscribe-auth/AC32BW7TNQOWMCUJVVIKG6LQDRIOFANCNFSM4IJ3BXSA .
@dchen97 Ah, got it! Mb for not reading your comment clearly there, sorry! I have changed the link of the "See the Oppia Difference" button.
Thanks @hoangviet1993!
Two comments:
For the section titles, the character spacing seems too tight ("Millions of children are not..."). Can we increase the spacing a bit please? The same goes for the rest of the page ("We cannot ignore the potential quality...," "Creating fun and effective learning for...," and so on.)
In the section, "Millions of children are not..." can we add a line of text below the infographic that links to the source? @dchen97 if you have the URL that'd be great :)
For the section titles, the character spacing seems too tight ("Millions of children are not..."). Can we increase the spacing a bit please? The same goes for the rest of the page
Done here and elsewhere!
In the section, "Millions of children are not..." can we add a line of text below the infographic that links to the source?
@rachelwchen I have added the source for the infographics. Can you PTAL again?
@seanlip Can you PTAL?
Looks good code-wise -- thanks @hoangviet1993!
I took a quick look at the demo page and I have one question. In the image at the bottom (the hub with 5 spokes showing 5 contributors), why is Anmol's photo repeated? We should replace it with an image that shows 5 unique people.
Hey Viet! In the "There's a role for you to play" section, can we increase the character spacing as well please? Right now it looks like it's about -0.5 to -0.6 -- I think it'll be more readable if it's at 0.0 :) thanks! Once that's done then I think we're ready!
Re: Sean's comment on the picture having duplicates -- in the "Built from a unified passion for educational equality" section, please use the image below instead. Thank you!
@rachelwchen I have deployed your image and increased the letter spacing like you suggested. PTAL at https://oppia-foundation-test-server.appspot.com/about
Thanks @hoangviet1993! I think the letter spacing is still a little tight in the last section, can we set it to 0 please:
@rachelwchen All done!
LGTM, please feel free to merge once tests pass. Thanks @hoangviet1993!
This PR revamp the current About page to provide more details about the Foundation in general.
Changes in this PR are live at: https://oppia-foundation-test-server.appspot.com/about
Some screenshots Desktop (1500px):
Tablet (iPad 2 horizontal rotation):
Mobile (ip6/7/8):