oppia / foundation-website

Repository for developing the new Oppia Foundation website.

Apache License 2.0

6 stars 32 forks source link

Added new Local Outreach and Artist Volunteer Descriptions #128

Closed dchen97 closed 4 years ago

dchen97 commented 4 years ago

Based on adjusted demand for particular roles, we decided to replace the "Design" volunteer description with an "Artist" description and the "Research" volunteer description with a "Local Outreach" member description.

dchen97 commented 4 years ago

Thanks for the review @hoangviet1993! Should be ready for another pass whenever you're ready

codecov-io commented 4 years ago

Codecov Report

Merging #128 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          21       21           
  Lines         411      411           
=======================================
  Hits          397      397           
  Misses         14       14

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24cfea8...440a243. Read the comment docs.

dchen97 commented 4 years ago

@seanlip - I believe I've addressed all of your comments (at least the ones I can address for now - I'll be sure to follow up on getting quotes from Yamama, Sam, and Rev. Bankas!). Ready for another pass whenever you're free!

seanlip commented 4 years ago

Hi @dchen97, make sure to reply to all comments please. I think you missed this one: https://github.com/oppia/foundation-website/pull/128#discussion_r364533396

But otherwise, LGTM! Thanks, and feel free to merge this once the Travis checks pass.