search

oppia / foundation-website

Repository for developing the new Oppia Foundation website.
Apache License 2.0
6 stars 33 forks source link

Volunteer tab content should not "scroll into place". #78

Closed seanlip closed 6 years ago

seanlip commented 6 years ago

When switching from tab to tab on the volunteer page, the content scrolls in from the right. This is a rather weird effect since switching tabs is a discrete and not a continuous event.

I'd suggest that, although the mini-carousels within each tab with the volunteer profiles should scroll, the tab content itself should not.

/cc @hoangviet1993

hoangviet1993 commented 6 years ago

The tab scrolling direction is relative from the current tab you are navigating away from.

Let's say you are currently at "Design" tab and you click on "Research", the tab will show the scrolling animation going from left to right, sort of like clicking on the "left" carousel button.

Let's say you are now at "Research" tab and you click on "Design", the tab will show the scrolling animation going from right to left, similar to that of clicking on the "right" carousel button.

With these details, do you still want to get rid of the tab scrolling animation? https://material.angularjs.org/latest/demo/tabs

Edit: md-tabs even support swipe left/right to traverse from one tab to another. Like if you drag your mouse from left to right on the tabs at https://material.angularjs.org/latest/demo/tabs#dynamic-tabs , the tab will scroll from left to right, which is probably dictated by some Material UI/UX(I hope) cos I don't think the folks at Angular Material likes doing fancy stuff just for the sake of doing it.

seanlip commented 6 years ago

Oh that's interesting. I didn't realize it was part of the standard md tab spec...

I guess let's leave it then, I still feel like the scrolling is as bit weird but not strongly enough to overrule what is presumably a standard design convention. Thanks for the explanation!