search

oppia / foundation-website

Repository for developing the new Oppia Foundation website.
Apache License 2.0
6 stars 32 forks source link

Override handle_exception to send email of backend exception's stack-trace #86

Closed hoangviet1993 closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #86 into master will increase coverage by 0.22%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   96.18%   96.41%   +0.22%     
==========================================
  Files          20       21       +1     
  Lines         367      390      +23     
==========================================
+ Hits          353      376      +23     
  Misses         14       14
Impacted Files Coverage Δ
app/core/tests/gae_suite.py 74.41% <ø> (ø) :arrow_up:
app/config.py 100% <100%> (ø) :arrow_up:
app/core/controllers/base.py 100% <100%> (ø) :arrow_up:
app/core/controllers/base_test.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4de919d...8b80749. Read the comment docs.

seanlip commented 5 years ago

Btw, bit surprised that coverage didn't pick this up -- it should have. Do we have python (backend) coverage + does it run on travis? If not, might be worth installing it.

hoangviet1993 commented 5 years ago

We do have coverage running on Travis and CircleCI. I think handle_exception is tested elsewhere in the codebase (but not particularly to send out email).