search

oppia / foundation-website

Repository for developing the new Oppia Foundation website.
Apache License 2.0
6 stars 32 forks source link

Fix #87: Relocate /oppia_tools to within the Foundation repo and parallelize CircleCI builds #89

Closed hoangviet1993 closed 5 years ago

hoangviet1993 commented 5 years ago

Fix #87

codecov-io commented 5 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         390      390           
=======================================
  Hits          376      376           
  Misses         14       14
Impacted Files Coverage Δ
app/core/tests/gae_suite.py 74.41% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04ae0ca...5935254. Read the comment docs.

hoangviet1993 commented 5 years ago

@seanlip I have broken up the former CircleCI's "build" into two separate tasks. I am not sure why it is still there and currently figuring out a way to get this PR in.

hoangviet1993 commented 5 years ago

@seanlip can you uncheck the "ci/circle: build" box in Github's branches menu? https://circleci.com/docs/2.0/workflows-waiting-status/

seanlip commented 5 years ago

Done!

apb7 commented 5 years ago

Hi @hoangviet1993, I was looking into this and I noticed that all CircleCI builds seem to be running for your fork (when I click on "Details"):

circleci1

and are run using the Oppia CircleCI account once the PR is pushed:

circlecioppia

I looked into another PR of facebook which uses CircleCI, https://github.com/facebook/react/pull/13912 and here CircleCI seems to be running using the organization's account:

circlecifb

Is this the intended behavior for CircleCI? I am pretty sure that Travis does not function this way. The "Details" link points to Oppia's Travis account.

Thanks!

hoangviet1993 commented 5 years ago

@apb7 That is because I have setup /foundation-website as one of my account's project. I have closed it down to test the build and now it is building from main Oppia's CircleCI account.

I think it is just how CircleCI behaves.

apb7 commented 5 years ago

@hoangviet1993: I see. Yup, now this is building using Oppia's CircleCI account. Thanks!