search

oppia / foundation-website

Repository for developing the new Oppia Foundation website.
Apache License 2.0
6 stars 32 forks source link

This PR is for debugging the lint issues. #98

Closed anubhavsinha98 closed 5 years ago

anubhavsinha98 commented 5 years ago

This PR fixes the htmllint issue and fix the wrong-import-order.

codecov-io commented 5 years ago

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files          21       21           
  Lines         390      390           
=======================================
  Hits          376      376           
  Misses         14       14
Impacted Files Coverage Δ
app/core/domain/email_manager.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1019c9c...59cef8a. Read the comment docs.

anubhavsinha98 commented 5 years ago

Hi @seanlip, below is the error message which was generated by the htmllint when we were using the social word.

Screenshot from 2019-04-17 12-36-19

anubhavsinha98 commented 5 years ago

Also we are using here htmllint and I went through the wiki of htmllint, and here it is mention : https://github.com/htmllint/htmllint/wiki/Options#id-class-no-ad

seanlip commented 5 years ago

Ah I see, thanks for explaining. Strange rule, but I think your fix is fine. Thanks!