Text size updating for other screens

oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.

https://www.oppia.org

Apache License 2.0

316 stars 517 forks source link

Text size updating for other screens #1540

Closed anandwana001 closed 2 years ago

anandwana001 commented 4 years ago

Describe the bug

[ ] Text Size of Exploration not changing as soon as we update the text size in options.
[x] Text Size also affecting the Options Screen text OptionsActivity as well as HelpActivity or any possible screen we can go after starting Exploration.

To Reproduce Steps to reproduce the behaviour: Go to any exploration -> click on overflow menu -> options -> change the text size -> back to exploration -> text size not changed -> leave the exploration -> enter the exploration again -> text size changed -> click on overflow menu -> text size of menu gets affected -> click on options or help -> you can see text size affected for all text on screen

Expected behaviour Text size should only be updated for the only exploration player, not any other screen

Screenshots

Device Pixel XL API 28

BenHenning commented 4 years ago

I think we shouldn't block alpha on this bug. While it's annoying, it's not totally app breaking & alpha is focusing on core functionality, not peripheral behaviors.

anandwana001 commented 4 years ago

I think we shouldn't block alpha on this bug. While it's annoying, it's not totally app breaking & alpha is focusing on core functionality, not peripheral behaviors.

Ok, Let's take this on later

rt4914 commented 4 years ago

@rt4914 Assigning this to myself for now so that I can divide this into multiple issues.

FareesHussain commented 3 years ago

@rt4914 I'll create a PR for the second bug in the description as the first bug requires some time

rt4914 commented 3 years ago

@rt4914 I'll create a PR for the second bug in the description as the first bug requires some time

@FareesHussain Sounds good.

prayutsu commented 3 years ago

/cc @BenHenning

When reading text size is updated, the other UI components like DialogFragment are also affected - Screenshot_2021-04-27-11-26-11-738_org oppia android

BenHenning commented 3 years ago

Note that this was found while testing alpha MR2 but is determined to not be a blocker.

rt4914 commented 2 years ago

@FareesHussain Unassigning you from this issue because of inactivity, please re-assign yourself if you are currently working on this.

MohitGupta121 commented 2 years ago

@BenHenning I'm try to reproduce this issue but for LessonFragment text size is changing as soon as we update, we need this as solution?

But for the RevisionFragment even Text Size is not changing from all ways. Text size changing is not implement for RevisionFragment or it's an issue?

https://user-images.githubusercontent.com/76530270/195115459-ce9a6b18-8c91-429d-8e6d-ae53d495945c.mp4

BenHenning commented 2 years ago

Thanks @MohitGupta121. I think this was fixed in #4411 so we can close this.