Closed anandwana001 closed 2 years ago
I think we shouldn't block alpha on this bug. While it's annoying, it's not totally app breaking & alpha is focusing on core functionality, not peripheral behaviors.
Ok
I think we shouldn't block alpha on this bug. While it's annoying, it's not totally app breaking & alpha is focusing on core functionality, not peripheral behaviors.
Ok, Let's take this on later
@rt4914 Assigning this to myself for now so that I can divide this into multiple issues.
@rt4914 I'll create a PR for the second bug in the description as the first bug requires some time
@rt4914 I'll create a PR for the second bug in the description as the first bug requires some time
@FareesHussain Sounds good.
/cc @BenHenning
When reading text size is updated, the other UI components like DialogFragment are also affected -
Note that this was found while testing alpha MR2 but is determined to not be a blocker.
@FareesHussain Unassigning you from this issue because of inactivity, please re-assign yourself if you are currently working on this.
@BenHenning I'm try to reproduce this issue but for LessonFragment
text size is changing as soon as we update, we need this as solution?
But for the RevisionFragment
even Text Size is not changing from all ways. Text size changing is not implement for RevisionFragment
or it's an issue?
Thanks @MohitGupta121. I think this was fixed in #4411 so we can close this.
Describe the bug
OptionsActivity
as well asHelpActivity
or any possible screen we can go after starting Exploration.To Reproduce Steps to reproduce the behaviour: Go to any exploration -> click on overflow menu ->
options
-> change the text size -> back to exploration -> text size not changed -> leave the exploration -> enter the exploration again -> text size changed -> click on overflow menu -> text size of menu gets affected -> click onoptions
orhelp
-> you can see text size affected for all text on screenExpected behaviour Text size should only be updated for the only exploration player, not any other screen
Screenshots
Device Pixel XL API 28