search

oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
320 stars 521 forks source link

Upgrade target SDK to 30 #3749

Open BenHenning opened 3 years ago

BenHenning commented 3 years ago

We are currently targeting SDK 28 but ought to target at least 30 (or 31 depending on when this issue gets resolved).

It's unclear all of the work needed here since the Bazel build environment is very specifically configured for 28 currently.

BenHenning commented 3 years ago

Possible blocker: #1542.

BenHenning commented 2 months ago

We're targeting SDK 33 now, so this is technically completed:

https://github.com/oppia/oppia-android/blob/0ef7a460ce1e41546f2ba1510ff12bbf88ad8177/build_flavors.bzl#L121

github-actions[bot] commented 2 months ago

The issue is reopened because of the following unresolved TODOs: https://github.com/oppia/oppia-android/blob/0ef7a460ce1e41546f2ba1510ff12bbf88ad8177/config/proguard/androidx-proguard-rules.pro#L2 https://github.com/oppia/oppia-android/blob/0ef7a460ce1e41546f2ba1510ff12bbf88ad8177/config/proguard/glide-proguard-rules.pro#L3 https://github.com/oppia/oppia-android/blob/0ef7a460ce1e41546f2ba1510ff12bbf88ad8177/config/proguard/material-proguard-rules.pro#L2

BenHenning commented 2 months ago

Looks like there are some Proguard file cleanups needed before this issue can be closed.