Open BenHenning opened 4 years ago
This should include thoroughly test each supported interaction, including for its placeholders and hint text.
From #410: Make sure we test the shortening of submitted answers.
Enough of #89 is now complete that this is no longer blocked.
I am working on this issue
@FareesHussain I think @kartikeysaran has not filled the CLA and survey form.
@kartikeysaran Thanks for showing interest but before you create a PR please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.
Also, this is not a good-first-issue
and therefore might need some extra context, so either feel free to ask questions in gitter or work on some other issue from https://github.com/oppia/oppia-android/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22good+first+issue%22
@FareesHussain I think @kartikeysaran has not filled the CLA and survey form.
@kartikeysaran Thanks for showing interest but before you create a PR please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.
Also, this is not a
good-first-issue
and therefore might need some extra context, so either feel free to ask questions in gitter or work on some other issue from https://github.com/oppia/oppia-android/issues?q=is%3Aopen+is%3Aissue+no%3Aassignee+label%3A%22good+first+issue%22
@rt4914 He has filled the CLA and survey form and I assigned it to him based on the discussion on Gitter.
@kartikeysaran as you are new to the codebase it is recommended to go for good-first-issues
first as @rt4914 mentioned so that you can get familiar with the codebase.
@kartikeysaran
Few points to get start:
How you can send a pr for this:
Let me know if you need any help in this.
Thankyou @anandwana001 for your help .
Hi, @kartikeysaran any update on this?
Hi, @kartikeysaran any update on this?
I was little busy with college work, will try to add tests asap
@kartikeysaran Thanks for the update, do follow the steps above mentioned
https://github.com/oppia/oppia-android/issues/388#issuecomment-772343108
@anandwana001 I am busy with my college projects this week if you want you can assign someone else to this issue
@MohitGupta121 will be working on auditing existing tests between StateFragmentTest, StateFragmentLocalTest, ExplorationActivityTest, and ExplorationActivityLocalTest to determine what gaps currently exist.
I am not getting proper time to concentrate on this issue as I'm first completing the dark mode issues for our next release that's why I unassigned myself this issue. When I free from all other issues then I concentrate on this issue. Thanks.
Sounds good--thanks @MohitGupta121!
Unassigning myself from this issue because I don't think I will have enough time to complete it.
Per #165 and #163 we did not thoroughly test the exploration & state experiences due to being blocked on #89 and #59. We need to complete this as it's essential to stabilize the exploration player and prevent regressions.
Test reference: https://github.com/oppia/oppia-android/blob/develop/app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentTest.kt#L206.
UPDATE: This is not blocked anymore and anyone can start working on tests.