search

oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
322 stars 522 forks source link

Update ktlint #4122

Open BenHenning opened 2 years ago

BenHenning commented 2 years ago

We should update ktlint to the latest version since it actually has some issues with Kotlin 1.4 (i.e. fun interface results in a ktlint failure that can't be worked around), but there are a lot of formatting changes that need to be addressed with this. It may be worth also integrating with ktfmt (i.e. #2799) before completing this since that will also require a codebase-wide refactor.

We should try to aim to do this between large projects to avoid too much churn, and ideally not during GSoC. Maybe sometime in March?

BenHenning commented 2 years ago

Related ktlint issue: https://github.com/pinterest/ktlint/issues/781 (fix was in 0.38.0).