Improve flow in onboarding screen

[vrajdesai78]

Describe the bug When we click next button in onboarding screen, focus will remain in next button instead of announcing current screen.

To Reproduce Steps to reproduce the behavior:

1. Clear app's data if Oppia app is already installed
2. Turn on Talkback.
3. Click on 'Next Button'.

Expected behavior When we click next button, talkback reader should read screen name.

Demonstration

https://user-images.githubusercontent.com/43074241/195674699-2c58a48a-f04f-47ef-8acc-ca3476da5c57.mp4

Environment

• Device/emulator being used: Realme GT Master Edition
• Android or SDK version (e.g. Android 5 or SDK 21): Android 12
• App version (you can get this through system app settings or via the admin controls menu in-app): 1.0

[iampradeep-hr]

Hi Can I work on this issue ?

[BenHenning]

This is actually a really challenging problem @iampradeep-hr as it's an issue with view pager, not Oppia code. I suggest looking at other open issues, instead.

[iampradeep-hr]

@BenHenning I have worked with ViewPager2 and I have some experience. I had commented on all the issues which i guess i able to solve.

[BenHenning]

@iampradeep-hr before I assign this to you, I think it’d be helpful to get an idea on how you’d approach it. Could you provide your thoughts on how this issue might be fixed?

[iampradeep-hr]

Ok Thanks, @BenHenning So I think we need to send AccessibilityEvents manually whenever the page is scrolled. The focus is not going to the next screen viewPager instead staying on next button itself. So in the onPageScrolled() callback I need to add the code which sends AccessiblityEvents focus changes to the system. This would solve it i guess.

[BenHenning]

That might work @iampradeep-hr but it'll depend on which events you send. We have to be careful to not re-route the user at a time the view pager itself might be trying to change the flow, and we don't want to interrupt anything being read out at that moment. If you think your solution can address these points as well, I'm happy to assign the issue over to you.

[iampradeep-hr]

@BenHenning

https://user-images.githubusercontent.com/81664507/202836668-6614dc9e-263c-4506-970a-3409f5199e8e.mp4

Yes, if we send only focus change events on the ViewPager then it would read only the ACTION_ACCESSIBILITY_FOCUS changes and it dosen't redirect / re-route the user anywhere. So here on pressing the next button the focus changes to ViewPager and announces the page number. once the user taps on the current page it announces the views.

[BenHenning]

Interesting! This looks like a really good UX. It may be worth checking how that flow behaves on a different screenreader (like Samsung's), but otherwise I think this is a really promising start, thanks @iampradeep-hr! Assigning this over to you.

Edit: Also, I suggest enabling "speech output" in the developer settings of Talkback as this can make it easier to see what Talkback is actually trying to verbalize (and works better when showing a11y flows as then people don't need to listen to the video).

[iampradeep-hr]

Hi @BenHenning, Is this the way it should work ?

https://user-images.githubusercontent.com/81664507/202853732-4ed5a364-0541-4977-bbed-78ec5bd92f8c.mp4

[BenHenning]

@iampradeep-hr I think that looks really good! That's exactly how I'd expect it to work, yep.

[iampradeep-hr]

@iampradeep-hr I think that looks really good! That's exactly how I'd expect it to work, yep.

Cool then, I would update the code changes in all the related layout files and create a PR.

[iampradeep-hr]

@BenHenning , here's the PR onboarding flow improved

[BenHenning]

Thanks @iampradeep-hr will take a look.

[adhiamboperes]

Unassigning @iampradeep-hr due to inactivity.