BenHenning
commented
4 months ago From #5138 the classes that need to be fixed:
- [ ] app/src/sharedTest/java/org/oppia/android/app/administratorcontrols/learneranalytics/ProfileAndDeviceIdActivityTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/AppCompatCheckBoxBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/CircularProgressIndicatorAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/DrawableBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/ImageViewBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/MarginBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerMarginBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/StateAssemblerPaddingBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/TextViewBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/databinding/ViewBindingAdaptersTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/devoptions/mathexpressionparser/MathExpressionParserFragmentTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/parser/HtmlParserTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/policies/PoliciesFragmentTest.kt
- [ ] app/src/sharedTest/java/org/oppia/android/app/utility/RatioExtensionsTest.kt
- [ ] app/src/test/java/org/oppia/android/app/activity/ActivityIntentFactoriesTest.kt
- [ ] app/src/test/java/org/oppia/android/app/activity/route/ActivityRouterModuleTest.kt
- [ ] app/src/test/java/org/oppia/android/app/activity/route/ActivityRouterTest.kt
- [ ] app/src/test/java/org/oppia/android/app/parser/FractionParsingUiErrorTest.kt
- [ ] app/src/test/java/org/oppia/android/app/parser/ListItemLeadingMarginSpanTest.kt
- [ ] app/src/test/java/org/oppia/android/app/parser/StringToRatioParserTest.kt
- [ ] app/src/test/java/org/oppia/android/app/translation/ActivityLanguageLocaleHandlerTest.kt
- [ ] app/src/test/java/org/oppia/android/app/translation/AppLanguageResourceHandlerTest.kt
- [ ] app/src/test/java/org/oppia/android/app/utility/datetime/DateTimeUtilTest.kt
- [ ] app/src/test/java/org/oppia/android/app/utility/math/MathExpressionAccessibilityUtilTest.kt
- [ ] domain/src/test/java/org/oppia/android/domain/oppialogger/analytics/ApplicationLifecycleObserverTest.kt
- [ ] scripts/src/javatests/org/oppia/android/scripts/regex/RegexPatternValidationCheckTest.kt
- [ ] testing/src/test/java/org/oppia/android/testing/espresso/TextInputActionTest.kt
Describe the bug
During the development of #5138 it was discovered that ActivityScenarioRule can cause issues with any module-override static initialization (such as platform parameters). This is most likely to happen with platform parameters, and it manifests as the parameters not properly setting for some of the tests (due to the scenario being set up before the module override can occur in the test).
Steps To Reproduce
Trying to run specific tests in ProfileAndDeviceIdFragmentTest can fail due to the platform parameters needed for the test not being properly set up ahead of the test running (running the whole suite doesn't fail since earlier tests don't depend on the parameter and give the module time to be initialized before the scenario actually sets up a UI which does require the parameters).
Expected Behavior
All tests should be able to be run independently of any particular execution order, especially with platform parameters.
All uses of ActivityScenarioRule should be removed and replaced with manual ActivityScenario management, as shown in ProfileAndDeviceIdFragmentTest (after #5138 is merged).
Screenshots/Videos
No response
What device/emulator are you using?
N/A -- test environment
Which Android version is your device/emulator running?
N/A -- test environment
Which version of the Oppia Android app are you using?
N/A -- test environment
Additional Context
No response