oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
311 stars 514 forks source link

Rename FAQ Strings #5347

Closed adhiamboperes closed 7 months ago

adhiamboperes commented 7 months ago

Explanation

Renamed FAQ question and answer strings from index-based to more descriptive qualifiers. The corresponding translations to the previous strings have been deleted. The goal is to to overwrite existing faq strings and re-translate them, since a number of updates were made in #5246 and #5332.

device-2024-02-22-030542.webm

Essential Checklist

For UI-specific PRs only

If your PR includes UI-related changes, then:

adhiamboperes commented 7 months ago

Waiting for CI to pass but LGTM from self-review.

adhiamboperes commented 7 months ago

@BenHenning, PTAL.

BenHenning commented 7 months ago

NB: The translated strings are okay to delete since much of the content has changed/moved around, so we're just going to require a re-translation of all of them. This does mean that the next app release may distribute these strings in English.

@seanlip do you see any need for us to block on FAQ translations for release 0.13?

oppiabot[bot] commented 7 months ago

Unassigning @BenHenning since they have already approved the PR.

oppiabot[bot] commented 7 months ago

Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

seanlip commented 7 months ago

NB: The translated strings are okay to delete since much of the content has changed/moved around, so we're just going to require a re-translation of all of them. This does mean that the next app release may distribute these strings in English.

@seanlip do you see any need for us to block on FAQ translations for release 0.13?

Thanks -- I think no need to block since I suspect this is a low-frequency screen. However I would like to ask if we could keep the existing translations for content whose ID has been renamed but the content itself has not changed, to minimize unnecessary translation work?

BenHenning commented 7 months ago

NB: The translated strings are okay to delete since much of the content has changed/moved around, so we're just going to require a re-translation of all of them. This does mean that the next app release may distribute these strings in English. @seanlip do you see any need for us to block on FAQ translations for release 0.13?

Thanks -- I think no need to block since I suspect this is a low-frequency screen. However I would like to ask if we could keep the existing translations for content whose ID has been renamed but the content itself has not changed, to minimize unnecessary translation work?

I do believe this requires us to edit the strings directly in TranslateWiki, doesn't it @seanlip? Whenever we directly check in translated strings they get overwritten by TranslateWiki (though I don't recall if we've ever tried this for new strings, so it may work for those).

Edit: Also, if there's a way we can communicate the old strings to translators that might be easier for us. I'm not familiar with all the changes that were done to the English strings, so it may be possible that some only require small translation adjustments.

seanlip commented 7 months ago

I do believe this requires us to edit the strings directly in TranslateWiki, doesn't it @seanlip? Whenever we directly check in translated strings they get overwritten by TranslateWiki (though I don't recall if we've ever tried this for new strings, so it may work for those).

@BenHenning Honestly I don't know. I think I'd suggest just doing it and seeing what happens, but I'm also fine either way.

Not sure of any direct way to communicate the old strings to translators, sorry.

BenHenning commented 7 months ago

I do believe this requires us to edit the strings directly in TranslateWiki, doesn't it @seanlip? Whenever we directly check in translated strings they get overwritten by TranslateWiki (though I don't recall if we've ever tried this for new strings, so it may work for those).

@BenHenning Honestly I don't know. I think I'd suggest just doing it and seeing what happens, but I'm also fine either way.

Not sure of any direct way to communicate the old strings to translators, sorry.

@adhiamboperes WDYT about trying to manually copy in the translations based on:

Do you think this could be done?

adhiamboperes commented 7 months ago

@BenHenning, I have brought back the translations. PTAL.