Fix #5195: Fix RestrictedApi Errors

XichengSpencer commented 7 months ago

Explanation

Fixes #5195 In the Android/Lint errors, all I can see are just NewApi Errors, which related methods are only available on API 26 and our current min API is 19. Correct me if I am wrong, as discussed with Ben in a meeting, most errors test-related file can be fixed by adding require api annotation, and for all the changed files I think they are test related so I added annotation. I did some investigation java.util.Time replacement method and it requires to install third-party dependency, which I think adds too much complexity so I proceed with the annotation way. And for the color matcher one, I cannot find the replacement method.

Essential Checklist

[z] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] Any changes to scripts/assets files have their rationale included in the PR explanation.
[x] The PR follows the style guide.
[x] The PR does not contain any unnecessary code changes from Android Studio (reference).
[x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
[x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
For PRs introducing new UI elements or color changes, both light and dark mode screenshots must be included
Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Screenshot 2024-02-21 092439

oppiabot[bot] commented 7 months ago

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot[bot] commented 6 months ago

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppiabot[bot] commented 6 months ago

Hi @XichengSpencer, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

adhiamboperes commented 6 months ago

@XichengSpencer, please reassign if this is ready for a review.

oppia / oppia-android