Closed Rd4dev closed 3 months ago
@adhiamboperes PTAL
Hi @adhiamboperes,
The third_party/versions.bzl file appears to be missing the CircularImageView
dependency.
It seems that PR #2659 might have overlooked the addition of com.jackandphantom.android:circularimageview
.
Two dependencies were initially employed for circular images:
de.hdodenhof:circleimageview:3.0.1 added initally via PR #326
com.jackandphantom.android:circularimageview:1.2.0 added initially via PR #959 Also to note: this dependency does exist in the third_party/versions.bzl file
Both dependencies were eventually mixed in layouts, with de.hdodenhof.circleimageview.CircleImageView
predominantly
[ref. PR #4155].
Issue #3258 mentions replacing com.jackandphantom.android:circularimageview
, but the comment suggests replacing de.hdodenhof.circleimageview.CircleImageView
as well which was implemented in PR #4155.
Seeking clarification on whether it is appropriate to proceed with the removal of de.hdodenhof.circleimageview.CircleImageView
, given that none of the layouts appear to utilize this dependency.
@Rd4dev , please remove the dependency as it is unused.
@adhiamboperes PTAL
Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!
@adhiamboperes PTAL
Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!
Unassigning @adhiamboperes since they have already approved the PR.
Assigning @BenHenning for code owner reviews. Thanks!
Updating with latest & enabling auto-merge since everything seems to look good.
Unassigning @BenHenning since they have already approved the PR.
Hi @Rd4dev, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!
Explanation
Fixes #3258
The Pull Request #4155 substituted
CircularImageView
withShapeableImageView
, yet the dependency persists in the project. This PR addresses the final steps of removing the remaining dependency.add_shadow
andshadow_radius
were exclusive toCircularImageView
. Upon removing the dependencies, these attributes became irrelevant, so they were omitted from the layouts. Their removal had no impact on the functioning views as they were unrelated to the actual attributes of the working views. [Attached reference images below]Essential Checklist
For UI-specific PRs only
Todo
Remove Dependency from Bazel and External libraries.!