Closed kkmurerwa closed 6 days ago
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @kkmurerwa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
@adhiamboperes this PR is ready for review now. PTAL
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Thanks @kkmurerwa. This looks good so far. I'm wondering if there's some kind of script or runtime failure that will ensure all new feature flags are added to app startup logging
@adhiamboperes Milestone 2 placed mechanisms to make sure that any feature flags introduced in the future will cause CI to fail as long as they are added to the feature flags logger. However, there is no objective way to make sure that feature flags added to the constants file are also added to the feature flags logger.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Thanks @kkmurerwa. This looks good so far. I'm wondering if there's some kind of script or runtime failure that will ensure all new feature flags are added to app startup logging
@adhiamboperes Milestone 2 placed mechanisms to make sure that any feature flags introduced in the future will cause CI to fail as long as they are added to the feature flags logger. However, there is no objective way to make sure that feature flags added to the constants file are also added to the feature flags logger.
I have filed https://github.com/oppia/oppia-android/issues/5445 so that we can find a way to do this.
Syncing with develop and enabling auto-merge.
@seanlip, could you please approve for oppia/owners?
Assigning @BenHenning for code owner reviews. Thanks!
Assigning @BenHenning for code owner reviews. Thanks!
Explanation
When merged, this PR will;
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: