search

oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
300 stars 502 forks source link

[BUG]: Setup instructions for JDK 8 on Mac no longer work #5384

Open kkmurerwa opened 2 months ago

kkmurerwa commented 2 months ago

Describe the bug

When working with the Bazel setup instructions for Mac, the step involving installing JDK 8 using AdoptOpenJDK and Homebrew no longer works and gives the error below.

image

This issue happens because the adoptopenjdk cask is being deprecated in favour of temurin.

Steps To Reproduce

Uninstall your AdoptOpenJDK8 and try to reinstall it using the instructions on step 3 of the Bazel Mac setup page.

Expected Behavior

I expect the installation to go on as expected.

To fix this issue, follow the steps below as described in the solution for this issue.

  1. Untap the AdoptOpenJDK Cask 

    brew untap AdoptOpenJDK/openjdk

  2. Update cask versions

    brew tap homebrew/cask-versions

  3. Install Temurin in the place of the AdoptOpenJDK cask

    brew install --cask temurin8

Screenshots/Videos

No response

What device/emulator are you using?

Pixel 3a

Which Android version is your device/emulator running?

Android 10

Which version of the Oppia Android app are you using?

No response

Additional Context

To work on this Issue, you need a Macbook. Test out the wiki instructions and apply the suggestion in this issue. If it works, create a PR to update the wiki.

While working on this issue, be sure to note down any issues you encounter during bazel set up.

adhiamboperes commented 2 months ago

@kkmurerwa, per the information you have provided in the issue, What changes need to be made? Is it only updating the documentation to point to temurin instead of openjdk?

kkmurerwa commented 2 months ago

@adhiamboperes that is correct. The only change needed is switching from AdoptOpenJDK to Temurin.

adhiamboperes commented 1 month ago

@kkmurerwa, https://github.com/oppia/oppia-android/pull/4886 updates Bazel to 6.5, and openjdk11. Has support for adoptopenjdk11 also been deprecated?