Closed adhiamboperes closed 14 hours ago
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
PTAL @BenHenning.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
It's a bit tricky to fully review this without the data part being hooked up, but the UI bits overall LGTM.
@BenHenning, I am unable to add the full language selection logic in this PR because it is dependent on profile availablity, which is not done until the next PR. I have however hooked up the language dropdown with the list of available languages in the latest changes. PTAL.
Hi @adhiamboperes, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Updated screenshots. There are no outstanding comments, so enabling auto-merge.
Explanation
Fix Part of https://github.com/oppia/oppia-android/issues/4938: New screen to allow a user to select an audio language during the onboarding process.
This PR only adds the layout and navigation functions without implementing the language selection functionality.
Essential Checklist