oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
300 stars 502 forks source link

Fix #2536: Introduce a central utility for matching item in RecyclerView #5391

Closed deonwaju closed 1 month ago

deonwaju commented 2 months ago

Explanation

Fix #2536

I worked on the below functions renaming the title and adding an argument for the recyclerviewId to each function to make it reusable, I also added kdocs to help understand the functions. P.S:- I created the functions in the RecyclerviewMatcher class.

Screenshot 2024-04-30 at 01 24 45

Screenshot 2024-04-30 at 01 24 26

Screenshot 2024-04-30 at 01 24 57

Essential Checklist

deonwaju commented 2 months ago

PTAL @adhiamboperes

oppiabot[bot] commented 2 months ago

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] commented 1 month ago

Hi @deonwaju, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

deonwaju commented 1 month ago

PTAL @adhiamboperes

oppiabot[bot] commented 1 month ago

Unassigning @deonwaju since a re-review was requested. @deonwaju, please make sure you have addressed all review comments. Thanks!