oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
300 stars 502 forks source link

Fix #1433 Logging Exceptions to Both Console and Exception Loggers #5396

Closed XichengSpencer closed 1 month ago

XichengSpencer commented 1 month ago

Explanation Fix #1433

There are 3 TODO marks the place where we want to have both have log in both Console and Exception Loggers By checking 3 related TODOs, only TODO in ExceptionController needs to add the exception logger for logging and I added it as the issue required and removed the TODO comment. The other 2 TODOs already meet the requirement of the issue, so I simply deleted TODO comments.

Essential Checklist

For UI-specific PRs only

If your PR includes UI-related changes, then:

oppiabot[bot] commented 1 month ago

Hi @XichengSpencer, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!