Fix #1535, part of #4120: Upgrade to rules_kotlin v1.5.0 beta 3

BenHenning commented 4 months ago

Explanation

Fixes #1535 Fixes part of #4120

This PR preps for the codebase-wide migration to Kotlin 1.6 (done in #4937) by first upgrading rules_kotlin from 1.5.0 alpha 2 to 1.5.0 beta 3. This upgrade, while small, produces a few nice benefits:

It removes the need for extra WORKSPACE dependency setup (thus addressing #1535).
It moves a bunch of rules_kotlin macros to new locations which results in changing nearly every BUILD.bazel file in the codebase.

The changes are straightforward to review in isolation, so this PR acts as a means to help reduce the complexity of #4937 by pulling ahead these groups of BUILD.bazel changes while also moving rules_kotlin the smallest number of versions (ahead of the more major upgrades which will occur downstream).

Note that this change is needed because:

We'll need to upgrade to a newer version of rules_kotlin in order to bring in Kotlin 1.6 support.
rules_kotlin moved these macros and using the old ones results in a lot of build warnings that spam the local console when trying to build.

Separately, this PR includes some minor trailing space cleanup in wiki/Oppia-Bazel-Setup-Instructions.md that was noticed when editing the file (since my local development environment auto-strips trailing spaces).

Essential Checklist

[x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
[x] Any changes to scripts/assets files have their rationale included in the PR explanation.
[x] The PR follows the style guide.
[x] The PR does not contain any unnecessary code changes from Android Studio (reference).
[x] The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
[x] The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

N/A -- This should only affect build infrastructure, and barely impact resulting binary builds.

BenHenning commented 4 months ago

PTAL @adhiamboperes. Note that I suspect this will be a quicker PR to review compared to some of the others that I've sent recently.

oppiabot[bot] commented 4 months ago

Hi @BenHenning, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

BenHenning commented 4 months ago

Thanks @adhiamboperes and @seanlip! Going ahead and merging this.

oppia / oppia-android