[Feature Request]: Replace type-ambiguous (and now deprecated) Bundle calls

[BenHenning]

Is your feature request related to a problem? Please describe.

API 33 (introduced in #5222) deprecated Bundle's generic methods:

• https://developer.android.com/reference/android/os/BaseBundle#get(java.lang.String).
• https://developer.android.com/reference/android/os/Bundle#getSerializable(java.lang.String)

5402 helped reveal which places need updating:

• [ ] app/src/main/java/org/oppia/android/app/options/OptionsActivity.kt
• [ ] app/src/main/java/org/oppia/android/app/testing/TestFontScaleConfigurationUtilActivity.kt
• [ ] app/src/main/java/org/oppia/android/app/topic/practice/TopicPracticeFragment.kt
• [ ] utility/src/main/java/org/oppia/android/util/extensions/BundleExtensions.kt
• [ ] utility/src/test/java/org/oppia/android/util/extensions/BundleExtensionsTest.kt

Describe the solution you'd like

Calls need to be replaced with either type-specific or BundleCompat calls, specifically:

• getSerializable() should now use https://developer.android.com/reference/androidx/core/os/BundleCompat#getSerializable(android.os.Bundle,java.lang.String,java.lang.Class%3CT%3E) instead.
• get() calls should be replaced with the 'get' method for the expected data type.

Describe alternatives you've considered

None--BundleCompat must be used for cases when we do not know the type since the app has a minimum supported SDK of 21.

Additional context

The app generally uses Bundles in one of two cases:

• Navigating to fragments & activities.
• Performing configuration changes (such as a device rotation).

All changes to fragments and activities need to be tested by:

• Ensuring they functionally work when being navigated to.
• Ensuring they functionally work after rotations to portrait and landscape (both orientations should be tested, and functionality should be tested both before and after the orientation change).

Some special notes:

• The first work on this issue will require updating AndroidX core to a newer version.
• The changes in utility/src/test/java/org/oppia/android/util/extensions/BundleExtensionsTest.kt require updating Robolectric (which probably will need to happen out-of-band as it's complicated) in order to configure that test to run on SDK 33. Also, the idea here is to use a type check to verify the exact type (for a stronger assertion), e.g.:

  assertThat(intent.getSerializableExtra("first_extra")).isNotInstanceOf(String::class.java)

• The changes in utility/src/main/java/org/oppia/android/util/extensions/BundleExtensions.kt require replacing the getTypedSerializable helper method entirely as it's essentially reimplementing the method from BundleCompat.
• Some of the type changes aren't trivial replacements as the semantics between casting a get() and using a type-specific method like getString are different: the former would throw an exception (if not using as?) and the latter would become null. This needs to be considered while performing the migration work.

[uphargaur]

@adhiamboperes can i work on this issue

[adhiamboperes]

@uphargaur, Sure.

[adhiamboperes]

@uphargaur, are you still working on this?

[uphargaur]

Yes I am working on it, sorry for delay got my exams this week.

[uphargaur]

@adhiamboperes I tried working on it, but I’m finding it difficult to locate the data class.

For example, in the image below, I'm unable to identify which class to use for reference. Could you help me find that, or should I create a data class depending on the use case?

[adhiamboperes]

@uphargaur, I do not understand the question. What is data class in reference to?