Closed BenHenning closed 4 months ago
@adhiamboperes PTAL for codeowners.
@kkmurerwa PTAL to verify that this addresses your points in #5399 as expected. I deviated slightly from the suggestions since installation ID should be retained on app restarts unless the database is deleted, whereas session ID should be regenerated.
Unassigning @kkmurerwa since they have already approved the PR.
Updating with latest develop and enabling auto-merge to unblock @kkmurerwa
Unassigning @adhiamboperes since they have already approved the PR.
Thanks much for the review @adhiamboperes!
Explanation
Fixes #5399
This PR addresses the problems outlined in #5399 by:
testGetInstallationId_secondAppOpen_providerReturnsSameInstallationIdValue
andtestFetchInstallationId_secondAppOpen_returnsSameInstallationIdValue
are correctly run in a newTestApplication
(as inspired bySplashActivityTest
).testGetSessionId_secondAppOpen_returnsNewRandomId
) which also has the added benefit of providing confidence that the earlier tests are correctly verifying that the installation ID isn't changing, as expected, on a new app instance.Essential Checklist
For UI-specific PRs only
N/A -- This is fixing a specific test and has no impact on UI behaviors.