oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
311 stars 514 forks source link

Fix #5399: Fix tests in LoggingIdentifierControllerTest #5409

Closed BenHenning closed 4 months ago

BenHenning commented 4 months ago

Explanation

Fixes #5399

This PR addresses the problems outlined in #5399 by:

Essential Checklist

For UI-specific PRs only

N/A -- This is fixing a specific test and has no impact on UI behaviors.

BenHenning commented 4 months ago

@adhiamboperes PTAL for codeowners.

@kkmurerwa PTAL to verify that this addresses your points in #5399 as expected. I deviated slightly from the suggestions since installation ID should be retained on app restarts unless the database is deleted, whereas session ID should be regenerated.

oppiabot[bot] commented 4 months ago

Unassigning @kkmurerwa since they have already approved the PR.

adhiamboperes commented 4 months ago

Updating with latest develop and enabling auto-merge to unblock @kkmurerwa

oppiabot[bot] commented 4 months ago

Unassigning @adhiamboperes since they have already approved the PR.

BenHenning commented 4 months ago

Thanks much for the review @adhiamboperes!