Closed theMr17 closed 1 week ago
@adhiamboperes PTAL. I have updated the classroom data files with the topic_ids
list as discussed. This PR is now ready for a review.
Unassigning @adhiamboperes since the review is done.
Hi @theMr17, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!
@adhiamboperes, I have addressed all the comments, PTAL.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Thanks for the review @BenHenning! I have addressed the comments, PTAL.
@BenHenning PTAL.
Merged the Kotlin and Bazel update changes.
@adhiamboperes / @theMr17 please go ahead and merge once you're ready (I didn't want to in case it broke any downstream chaining).
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Note that this is a summarized snapshot. See the CI artifacts for detailed differences.
Explanation
Fixes part of #5344
ClassroomIdList
,ClassroomSummary
, &EphemeralClassroomSummary
and updatesClassroomList
to contain a list ofEphemeralClassroomSummary
s and awritten_translation_context
.classroomId
&classroomTitle
.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: