search

oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
298 stars 502 forks source link

Fix part of #5343: Update the test exemption check script & its exemption format #5426

Closed Rd4dev closed 1 week ago

Rd4dev commented 1 week ago

Explanation

Fixes part of #5343

Project [PR 1.2 of Project 4.1] This PR is based on develop as it had no other dependency with other PRs.

Changes Implemented

This PR implements updates to enhance the handling of file exemptions and code coverage settings:

  1. Updates script_exemptions.proto to support two possible states:

    • Exemption from requiring a test file (current behavior).
    • Override of the minimum code coverage to meet a specific percentage (including 0%).

  2. Aligns test_file_exemptions.textproto with the new proto format.

  3. Modifies TestFileCheck.kt to integrate the updated proto format.

Project Context

In Project 4.1, we are introducing code coverage capabilities where certain files may require exemptions from the default minimum code coverage percentage. These exemptions can now be managed in test_file_exemptions.textproto by setting the override_min_coverage_percentage.

Implementation Details

Initially, I explored using the TodoOpenCheck regeneration structure to implement these changes. However, due to significant differences in regeneration requirements (creating a new proto format to regenerate the exemptions list), conflicts arose with generate_test_file_assets_list_from_text_protos.

Given that the regeneration process is solely aimed at rebuilding the textproto file and no longer serves any other purpose in this project, I opted to manually compile a list of exempted files and used it to generate the new proto format. I then transferred this newly generated format to the textproto file. The regeneration implementation can be found in my local test_exemption branch

Post-generation, the regeneration functionality was removed, as it no longer aligns with the project's needs. Further validation and adjustments, if necessary, will be discussed with Ben and implemented.

Essential Checklist

For UI-specific PRs only

If your PR includes UI-related changes, then:

Rd4dev commented 1 week ago

@BenHenning can you PTAL!

github-actions[bot] commented 1 week ago

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics ### Universal APK APK file size: 16 MiB (old), 16 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **9 bytes** (Removed) Method count: 221791 (old), 221791 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 6550 (old), 6550 (new), **0** (No change) - Anim: 49 (old), 49 (new), **0** (No change) - Animator: 20 (old), 20 (new), **0** (No change) - Array: 15 (old), 15 (new), **0** (No change) - Attr: 915 (old), 915 (new), **0** (No change) - Bool: 10 (old), 10 (new), **0** (No change) - Color: 911 (old), 911 (new), **0** (No change) - Dimen: 994 (old), 994 (new), **0** (No change) - Drawable: 373 (old), 373 (new), **0** (No change) - Id: 1206 (old), 1206 (new), **0** (No change) - Integer: 37 (old), 37 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 368 (old), 368 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - Raw: 2 (old), 2 (new), **0** (No change) - String: 805 (old), 805 (new), **0** (No change) - Style: 816 (old), 816 (new), **0** (No change) - Xml: 6 (old), 6 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 15 MiB (old), 15 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **14 bytes** (Added) #### Configuration hdpi APK file size: 59 KiB (old), 59 KiB (new), **0 bytes** (No change) APK download size (estimated): 23 KiB (old), 23 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 56 KiB (old), 56 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 53 KiB (old), 53 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 102 KiB (old), 102 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 67 KiB (old), 67 KiB (new), **0 bytes** (No change) APK download size (estimated): 28 KiB (old), 28 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 76 KiB (old), 76 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 79 KiB (old), 79 KiB (new), **0 bytes** (No change) APK download size (estimated): 39 KiB (old), 39 KiB (new), **0 bytes** (No change)
## Alpha
Expand to see flavor specifics ### Universal APK APK file size: 10 MiB (old), 10 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9150 KiB (old), 9150 KiB (new), **21 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9030 KiB (old), 9030 KiB (new), **13 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Beta
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9135 KiB (old), 9135 KiB (new), **31 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9019 KiB (old), 9019 KiB (new), **4 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Ga
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9136 KiB (old), 9136 KiB (new), **21 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9020 KiB (old), 9020 KiB (new), **21 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
github-actions[bot] commented 1 week ago

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics ### Universal APK APK file size: 16 MiB (old), 16 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **9 bytes** (Removed) Method count: 221791 (old), 221791 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 6550 (old), 6550 (new), **0** (No change) - Anim: 49 (old), 49 (new), **0** (No change) - Animator: 20 (old), 20 (new), **0** (No change) - Array: 15 (old), 15 (new), **0** (No change) - Attr: 915 (old), 915 (new), **0** (No change) - Bool: 10 (old), 10 (new), **0** (No change) - Color: 911 (old), 911 (new), **0** (No change) - Dimen: 994 (old), 994 (new), **0** (No change) - Drawable: 373 (old), 373 (new), **0** (No change) - Id: 1206 (old), 1206 (new), **0** (No change) - Integer: 37 (old), 37 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 368 (old), 368 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - Raw: 2 (old), 2 (new), **0** (No change) - String: 805 (old), 805 (new), **0** (No change) - Style: 816 (old), 816 (new), **0** (No change) - Xml: 6 (old), 6 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 15 MiB (old), 15 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **14 bytes** (Added) #### Configuration hdpi APK file size: 59 KiB (old), 59 KiB (new), **0 bytes** (No change) APK download size (estimated): 23 KiB (old), 23 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 56 KiB (old), 56 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 53 KiB (old), 53 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 102 KiB (old), 102 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 67 KiB (old), 67 KiB (new), **0 bytes** (No change) APK download size (estimated): 28 KiB (old), 28 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 76 KiB (old), 76 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 79 KiB (old), 79 KiB (new), **0 bytes** (No change) APK download size (estimated): 39 KiB (old), 39 KiB (new), **0 bytes** (No change)
## Alpha
Expand to see flavor specifics ### Universal APK APK file size: 10 MiB (old), 10 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9150 KiB (old), 9150 KiB (new), **21 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9030 KiB (old), 9030 KiB (new), **13 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Beta
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9135 KiB (old), 9135 KiB (new), **31 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9019 KiB (old), 9019 KiB (new), **4 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Ga
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9136 KiB (old), 9136 KiB (new), **21 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9020 KiB (old), 9020 KiB (new), **21 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
Rd4dev commented 1 week ago

@BenHenning added the test case to verify that a min coverage exemption results in the file not being exempted, PTAL!

oppiabot[bot] commented 1 week ago

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

github-actions[bot] commented 1 week ago

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics ### Universal APK APK file size: 16 MiB (old), 16 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **11 bytes** (Removed) Method count: 221791 (old), 221791 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 6550 (old), 6550 (new), **0** (No change) - Anim: 49 (old), 49 (new), **0** (No change) - Animator: 20 (old), 20 (new), **0** (No change) - Array: 15 (old), 15 (new), **0** (No change) - Attr: 915 (old), 915 (new), **0** (No change) - Bool: 10 (old), 10 (new), **0** (No change) - Color: 911 (old), 911 (new), **0** (No change) - Dimen: 994 (old), 994 (new), **0** (No change) - Drawable: 373 (old), 373 (new), **0** (No change) - Id: 1206 (old), 1206 (new), **0** (No change) - Integer: 37 (old), 37 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 368 (old), 368 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - Raw: 2 (old), 2 (new), **0** (No change) - String: 805 (old), 805 (new), **0** (No change) - Style: 816 (old), 816 (new), **0** (No change) - Xml: 6 (old), 6 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 15 MiB (old), 15 MiB (new), **4 bytes** (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), **18 bytes** (Removed) #### Configuration hdpi APK file size: 59 KiB (old), 59 KiB (new), **0 bytes** (No change) APK download size (estimated): 23 KiB (old), 23 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 56 KiB (old), 56 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 53 KiB (old), 53 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 102 KiB (old), 102 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 67 KiB (old), 67 KiB (new), **0 bytes** (No change) APK download size (estimated): 28 KiB (old), 28 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 76 KiB (old), 76 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 79 KiB (old), 79 KiB (new), **0 bytes** (No change) APK download size (estimated): 39 KiB (old), 39 KiB (new), **0 bytes** (No change)
## Alpha
Expand to see flavor specifics ### Universal APK APK file size: 10 MiB (old), 10 MiB (new), **4 bytes** (Added) APK download size (estimated): 9150 KiB (old), 9150 KiB (new), **0 bytes** (No change) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9030 KiB (old), 9030 KiB (new), **4 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Beta
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9135 KiB (old), 9135 KiB (new), **9 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9019 KiB (old), 9019 KiB (new), **17 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Ga
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9136 KiB (old), 9136 KiB (new), **7 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9020 KiB (old), 9020 KiB (new), **1 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
Rd4dev commented 1 week ago

Thanks for the review and suggestions @BenHenning, added the required test cases for validating coverage exemption checks too, can you PTAL!

oppiabot[bot] commented 1 week ago

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

github-actions[bot] commented 1 week ago

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics ### Universal APK APK file size: 16 MiB (old), 16 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **7 bytes** (Added) Method count: 221791 (old), 221791 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 6550 (old), 6550 (new), **0** (No change) - Anim: 49 (old), 49 (new), **0** (No change) - Animator: 20 (old), 20 (new), **0** (No change) - Array: 15 (old), 15 (new), **0** (No change) - Attr: 915 (old), 915 (new), **0** (No change) - Bool: 10 (old), 10 (new), **0** (No change) - Color: 911 (old), 911 (new), **0** (No change) - Dimen: 994 (old), 994 (new), **0** (No change) - Drawable: 373 (old), 373 (new), **0** (No change) - Id: 1206 (old), 1206 (new), **0** (No change) - Integer: 37 (old), 37 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 368 (old), 368 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - Raw: 2 (old), 2 (new), **0** (No change) - String: 805 (old), 805 (new), **0** (No change) - Style: 816 (old), 816 (new), **0** (No change) - Xml: 6 (old), 6 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 15 MiB (old), 15 MiB (new), **8 bytes** (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), **28 bytes** (Removed) #### Configuration hdpi APK file size: 59 KiB (old), 59 KiB (new), **0 bytes** (No change) APK download size (estimated): 23 KiB (old), 23 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 56 KiB (old), 56 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 53 KiB (old), 53 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 102 KiB (old), 102 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 67 KiB (old), 67 KiB (new), **0 bytes** (No change) APK download size (estimated): 28 KiB (old), 28 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 76 KiB (old), 76 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 79 KiB (old), 79 KiB (new), **0 bytes** (No change) APK download size (estimated): 39 KiB (old), 39 KiB (new), **0 bytes** (No change)
## Alpha
Expand to see flavor specifics ### Universal APK APK file size: 10 MiB (old), 10 MiB (new), **4 bytes** (Added) APK download size (estimated): 9150 KiB (old), 9150 KiB (new), **2 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9030 KiB (old), 9030 KiB (new), **9 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Beta
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9135 KiB (old), 9135 KiB (new), **24 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9019 KiB (old), 9019 KiB (new), **2 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Ga
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9136 KiB (old), 9136 KiB (new), **15 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9020 KiB (old), 9020 KiB (new), **6 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
BenHenning commented 1 week ago

Feel free to merge this @Rd4dev if you don't intend to make any follow-up changes. If you do make follow-up changes, please assign back so I can look at them.

oppiabot[bot] commented 1 week ago

Assigning @adhiamboperes for code owner reviews. Thanks!

Rd4dev commented 1 week ago

Hey @BenHenning, I removed the kDocs for the private methods in TestFileCheck.kt. Can you PTAL? Also, I'm wondering if I can merge this if it's not from upstream?

oppiabot[bot] commented 1 week ago

Unassigning @Rd4dev since a re-review was requested. @Rd4dev, please make sure you have addressed all review comments. Thanks!

github-actions[bot] commented 1 week ago

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics ### Universal APK APK file size: 16 MiB (old), 16 MiB (new), **4 bytes** (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), **17 bytes** (Removed) Method count: 221791 (old), 221791 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 6550 (old), 6550 (new), **0** (No change) - Anim: 49 (old), 49 (new), **0** (No change) - Animator: 20 (old), 20 (new), **0** (No change) - Array: 15 (old), 15 (new), **0** (No change) - Attr: 915 (old), 915 (new), **0** (No change) - Bool: 10 (old), 10 (new), **0** (No change) - Color: 911 (old), 911 (new), **0** (No change) - Dimen: 994 (old), 994 (new), **0** (No change) - Drawable: 373 (old), 373 (new), **0** (No change) - Id: 1206 (old), 1206 (new), **0** (No change) - Integer: 37 (old), 37 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 368 (old), 368 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - Raw: 2 (old), 2 (new), **0** (No change) - String: 805 (old), 805 (new), **0** (No change) - Style: 816 (old), 816 (new), **0** (No change) - Xml: 6 (old), 6 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 15 MiB (old), 15 MiB (new), **8 bytes** (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), **26 bytes** (Removed) #### Configuration hdpi APK file size: 59 KiB (old), 59 KiB (new), **0 bytes** (No change) APK download size (estimated): 23 KiB (old), 23 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 56 KiB (old), 56 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 53 KiB (old), 53 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 102 KiB (old), 102 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 67 KiB (old), 67 KiB (new), **0 bytes** (No change) APK download size (estimated): 28 KiB (old), 28 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 76 KiB (old), 76 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 79 KiB (old), 79 KiB (new), **0 bytes** (No change) APK download size (estimated): 39 KiB (old), 39 KiB (new), **0 bytes** (No change)
## Alpha
Expand to see flavor specifics ### Universal APK APK file size: 10 MiB (old), 10 MiB (new), **4 bytes** (Added) APK download size (estimated): 9150 KiB (old), 9150 KiB (new), **3 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9030 KiB (old), 9030 KiB (new), **0 bytes** (No change) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Beta
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9135 KiB (old), 9135 KiB (new), **14 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Added) APK download size (estimated): 9019 KiB (old), 9019 KiB (new), **18 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Ga
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9136 KiB (old), 9136 KiB (new), **13 bytes** (Added) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **8 bytes** (Added) APK download size (estimated): 9020 KiB (old), 9020 KiB (new), **20 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)