search

oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
311 stars 514 forks source link

Fix #5428: Remove kotlin-android-extensions plugin #5429

Closed BenHenning closed 3 months ago

BenHenning commented 3 months ago

Explanation

Fixes #5428

This PR removes all occurrences of the kotlin-android-extensions plugin.

See the issue for specifics, but it seems the plugin wasn't actually being used anywhere (due to it never being enabled in Bazel and the old code that depended on it being removed years ago), so this only affects Gradle builds & tests. It should be a mostly benign change.

Essential Checklist

For UI-specific PRs only

This isn't expected to impact the user experience at all. For Gradle builds, it's possible the final build changes a bit, but that should be innocuous since the plugin isn't actually being used for anything. Bazel builds are unaffected.

BenHenning commented 3 months ago

PTAL @adhiamboperes & @theMr17. I suspect we can mainly rely on CI here, so I'm happy to enable auto-merge.

It might be nice to wait for build stats to run in ~10-11 hours, but if this is imminently blocking your work @theMr17 then I'd prefer we merge it sooner rather than waiting.

adhiamboperes commented 3 months ago

I'll approve this after the build stats. Thanks @BenHenning!

BenHenning commented 3 months ago

I'll approve this after the build stats. Thanks @BenHenning!

It actually occurred to me well after the above comment that build stats will be a no-op for this PR. :) The Bazel build is unaffected.

theMr17 commented 3 months ago

It might be nice to wait for build stats to run in ~10-11 hours, but if this is imminently blocking your work @theMr17 then I'd prefer we merge it sooner rather than waiting.

I am fine with waiting for a few hours for the build stats.

github-actions[bot] commented 3 months ago

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics ### Universal APK APK file size: 16 MiB (old), 16 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **10 bytes** (Added) Method count: 221791 (old), 221791 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 6550 (old), 6550 (new), **0** (No change) - Anim: 49 (old), 49 (new), **0** (No change) - Animator: 20 (old), 20 (new), **0** (No change) - Array: 15 (old), 15 (new), **0** (No change) - Attr: 915 (old), 915 (new), **0** (No change) - Bool: 10 (old), 10 (new), **0** (No change) - Color: 911 (old), 911 (new), **0** (No change) - Dimen: 994 (old), 994 (new), **0** (No change) - Drawable: 373 (old), 373 (new), **0** (No change) - Id: 1206 (old), 1206 (new), **0** (No change) - Integer: 37 (old), 37 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 368 (old), 368 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - Raw: 2 (old), 2 (new), **0** (No change) - String: 805 (old), 805 (new), **0** (No change) - Style: 816 (old), 816 (new), **0** (No change) - Xml: 6 (old), 6 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 15 MiB (old), 15 MiB (new), **0 bytes** (No change) APK download size (estimated): 14 MiB (old), 14 MiB (new), **5 bytes** (Added) #### Configuration hdpi APK file size: 59 KiB (old), 59 KiB (new), **0 bytes** (No change) APK download size (estimated): 23 KiB (old), 23 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 56 KiB (old), 56 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 53 KiB (old), 53 KiB (new), **0 bytes** (No change) APK download size (estimated): 18 KiB (old), 18 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 102 KiB (old), 102 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 67 KiB (old), 67 KiB (new), **0 bytes** (No change) APK download size (estimated): 28 KiB (old), 28 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 76 KiB (old), 76 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 79 KiB (old), 79 KiB (new), **0 bytes** (No change) APK download size (estimated): 39 KiB (old), 39 KiB (new), **0 bytes** (No change)
## Alpha
Expand to see flavor specifics ### Universal APK APK file size: 10 MiB (old), 10 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9150 KiB (old), 9150 KiB (new), **19 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9030 KiB (old), 9030 KiB (new), **3 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Beta
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9135 KiB (old), 9135 KiB (new), **20 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9019 KiB (old), 9019 KiB (new), **5 bytes** (Added) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)
## Ga
Expand to see flavor specifics ### Universal APK APK file size: 9 MiB (old), 9 MiB (new), **0 bytes** (No change) APK download size (estimated): 9136 KiB (old), 9136 KiB (new), **2 bytes** (Removed) Method count: 99436 (old), 99436 (new), **0** (No change) Features: 2 (old), 2 (new), **0** (No change) Permissions: 6 (old), 6 (new), **0** (No change) Resources: 5504 (old), 5504 (new), **0** (No change) - Anim: 39 (old), 39 (new), **0** (No change) - Animator: 18 (old), 18 (new), **0** (No change) - Array: 14 (old), 14 (new), **0** (No change) - Attr: 879 (old), 879 (new), **0** (No change) - Bool: 8 (old), 8 (new), **0** (No change) - Color: 767 (old), 767 (new), **0** (No change) - Dimen: 722 (old), 722 (new), **0** (No change) - Drawable: 333 (old), 333 (new), **0** (No change) - Id: 1148 (old), 1148 (new), **0** (No change) - Integer: 32 (old), 32 (new), **0** (No change) - Interpolator: 11 (old), 11 (new), **0** (No change) - Layout: 327 (old), 327 (new), **0** (No change) - Menu: 1 (old), 1 (new), **0** (No change) - Mipmap: 1 (old), 1 (new), **0** (No change) - Plurals: 10 (old), 10 (new), **0** (No change) - String: 736 (old), 736 (new), **0** (No change) - Style: 457 (old), 457 (new), **0** (No change) - Xml: 1 (old), 1 (new), **0** (No change) Lesson assets: 105 (old), 105 (new), **0** (No change) ### AAB differences
Expand to see AAB specifics Supported configurations: - hdpi (same) - ldpi (same) - mdpi (same) - tvdpi (same) - xhdpi (same) - xxhdpi (same) - xxxhdpi (same) #### Base APK APK file size: 9 MiB (old), 9 MiB (new), **4 bytes** (Removed) APK download size (estimated): 9020 KiB (old), 9020 KiB (new), **2 bytes** (Removed) #### Configuration hdpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 22 KiB (old), 22 KiB (new), **0 bytes** (No change) #### Configuration ldpi APK file size: 52 KiB (old), 52 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration mdpi APK file size: 46 KiB (old), 46 KiB (new), **0 bytes** (No change) APK download size (estimated): 17 KiB (old), 17 KiB (new), **0 bytes** (No change) #### Configuration tvdpi APK file size: 90 KiB (old), 90 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xhdpi APK file size: 60 KiB (old), 60 KiB (new), **0 bytes** (No change) APK download size (estimated): 27 KiB (old), 27 KiB (new), **0 bytes** (No change) #### Configuration xxhdpi APK file size: 69 KiB (old), 69 KiB (new), **0 bytes** (No change) APK download size (estimated): 37 KiB (old), 37 KiB (new), **0 bytes** (No change) #### Configuration xxxhdpi APK file size: 71 KiB (old), 71 KiB (new), **0 bytes** (No change) APK download size (estimated): 38 KiB (old), 38 KiB (new), **0 bytes** (No change)