oppia / oppia-android

A free, online & offline learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
311 stars 514 forks source link

Re-bump version codes for version 0.13 RC01 and test-only release #5438

Closed BenHenning closed 3 months ago

BenHenning commented 3 months ago

Explanation

This updates version codes for the 0.13 beta release of Oppia Android. #5389 was made without an actual release taking place, and we've since launched a test version of the app using release automation that used up version code 151. Thus, this brings version codes 2 releases past version code 151:

Essential Checklist

For UI-specific PRs only

N/A -- build infrastructure-only change.

BenHenning commented 3 months ago

@seanlip PTAL for codeowners.

adhiamboperes commented 3 months ago

@BenHenning, Just checking. PR description says, -7 from the version codes in this PR, do you mean Math minus since it's not clear from the values? I may have misunderstood.

BenHenning commented 3 months ago

@BenHenning, Just checking. PR description says, -7 from the version codes in this PR, do you mean Math minus since it's not clear from the values? I may have misunderstood.

Apologies @adhiamboperes for the lack of clarity. What I meant was that since each release RC has 7 version codes associated with it (for each of the possible flavors of that release), this PR is bumping forward the version codes for two release candidates from version code 151 (since that's the newest version pushed to play console, and we need to push releases with larger version codes).

Does that help clarify?

adhiamboperes commented 3 months ago

@BenHenning, Just checking. PR description says, -7 from the version codes in this PR, do you mean Math minus since it's not clear from the values? I may have misunderstood.

Apologies @adhiamboperes for the lack of clarity. What I meant was that since each release RC has 7 version codes associated with it (for each of the possible flavors of that release), this PR is bumping forward the version codes for two release candidates from version code 151 (since that's the newest version pushed to play console, and we need to push releases with larger version codes).

Does that help clarify?

Got it, Thanks. I thought that you meant the numeric dfference in previous vs current codes 😁

BenHenning commented 3 months ago

Thanks @adhiamboperes!

BenHenning commented 3 months ago

Merging since this doesn't actually need @seanlip's review, and @adhiamboperes reviewed it.