search

oppia / oppia-web-developer-docs

Repo for Web developer documentation on Oppia. For contribution instructions, see: https://github.com/oppia/oppia/wiki/Wiki#contributing-to-the-wiki
Apache License 2.0
10 stars 93 forks source link

Debugging E2E test wiki contains stale information #317

Open Nik-09 opened 4 months ago

Nik-09 commented 4 months ago

The debugging e2e test wiki contains some stale or incorrect information. For example, here the wiki page says to enable video recording for all the test cases of a test suite, we need to set saveAllVideos as true. But I did not find any variable with this name, although a variable with the name ALL_VIDEOS is present, which is actually used to enable videos for all the test cases.

Secondly, after following the steps mentioned in the wiki for enabling video recoding, I am still not able to get the recordings in the GitHub artifacts (in the summary of a CI run). This information in the wiki might also need an update.

U8NWXD commented 4 months ago

@Nik-09 I think you're almost there. In the GitHub Actions workflow, we only upload videos if the workflow failed:

https://github.com/oppia/oppia/blob/e566c34f7b92c5e2cdb03bf18b26d6408f5647ae/.github/workflows/e2e_lighthouse_performance_acceptance_tests.yml#L198.

You'll need to change that too

seanlip commented 4 months ago

@Nik-09 Please confirm the above works and post verification here -- then we can update the wiki. Thanks!