oppia / oppia-web-developer-docs

Repo for Web developer documentation on Oppia. For contribution instructions, see: https://github.com/oppia/oppia/wiki/Wiki#contributing-to-the-wiki
Apache License 2.0
10 stars 94 forks source link

Document approval requirements for new dependencies #327

Open U8NWXD opened 4 months ago

U8NWXD commented 4 months ago

When deciding whether to approve a new dependency, I've been informally checking for a few criteria. We should formalize these criteria, so I've put them into this checklist:

My intention is that after the colon (:) for each ticked box, we document our reasons for ticking the box. The OpenSSF security scorecards are a useful way to check many of these points. Here's an example usage: https://github.com/oppia/oppia/pull/20362#discussion_r1626804621

If this process sounds good, I propose putting this into the wiki and copying it into the review comment for each PR adding a dependency.

seanlip commented 4 months ago

Just noting that this sounds fine to me -- thanks!