search

oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.64k stars 3.79k forks source link

Replace Material Icons with Font Awesome icons #15968

Closed JayVivarekar closed 1 year ago

JayVivarekar commented 1 year ago

The Oppia frontend uses two icon families namely Font Awesome and Material icons. It has been decided to do away with Material icons throughout the frontend code and use only Font Awesome icons. This issue requires you to replace the material icons with corresponding (or similar) Font Awesome icons.

Getting Assigned.

Select around three files from the list given below and ask @JayVivarekar or @vojtechjelinek to assign them to you.

Instructions

  1. After a file is assigned to you, go through that file and find the occurrences of Material Icons in them.
  2. For a given occurrence, run the Oppia server locally and try to find the icon in the frontend.
  3. Replace the icon to the closest Font Awesome 5 icon you can find. You can search through all available icons here . Make sure to use only "Free" icons.
  4. If you are confused regarding which icon to use, feel free to ask @JayVivarekar or @vojtechjelinek.
  5. Make sure to screenshot all the icons that you've replaced (before and after) and put these screenshots in the PR description.

NOTE : You might need to modify the relevant CSS files to get correct appearance of the replaced icon.

PR for reference

15926

List of files with material icons

JayVivarekar commented 1 year ago

@vojtechjelinek @JayVivarekar Icon in the below file is already Font-awesome icon . Can you please clarify it? Thanks! oppia/core/templates/pages/library-page/search-bar/search-bar.component.html

@SubhashThenua You are correct. Thanks for pointing it out. Can you select some other file to work on?

kimchavsov commented 1 year ago

@vojtechjelinek @JayVivarekar Hi, I would like to work on this issue. Please assign some of the tasks to me.

JayVivarekar commented 1 year ago

@rishabhknowss I have assigned you the following files: oppia/core/templates/components/state-directives/outcome-editor/outcome-editor.component.html oppia/core/templates/components/state-directives/solution-editor/solution-editor.component.html oppia/core/templates/components/state-directives/solution-editor/solution-explanation-editor.component.html

JayVivarekar commented 1 year ago

@kimchavsov I have assigned you the following files: oppia/core/templates/pages/contributor-dashboard-admin-page/navbar/contributor-dashboard-admin-navbar.component.html oppia/core/templates/pages/contributor-dashboard-page/translation-language-selector/translation-language-selector.component.html oppia/core/templates/pages/exploration-editor-page/translation-tab/state-translation-editor/state-translation-editor.component.html

NPDebs commented 1 year ago

Hi @JayVivarekar 👋🏼 I'm an Outreachy participant and I'd love to work on this issue.

Could you please assign me some tasks?

gnurris commented 1 year ago

Hello @JayVivarekar I'd like to work on this issue. Could you please assign me some tasks?

sambhavgupta0705 commented 1 year ago

Hello @JayVivarekar I would like to work on this issue. Could you please assign me some tasks

k-gourav commented 1 year ago

Hey @vojtechjelinek and @JayVivarekar ! Could you assign me the following files:

● oppia/core/templates/pages/teach-page/teach-page.component.html ● oppia/core/templates/pages/story-viewer-page/navbar-pre-logo-action/story-viewer-navbar-pre-logo-action.component.html ● oppia/core/templates/components/question-directives/question-misconception-selector/question-misconception-selector.component.html https://twitter.com/dwarfstar99 for better reach ✨

JayVivarekar commented 1 year ago

@NPDebs @gnurris @sambhavgupta0705 @Dwarfstar-099 All files are assigned right now. Will assign something if any of them open up.

NPDebs commented 1 year ago

@NPDebs @gnurris @sambhavgupta0705 @Dwarfstar-099 All files are assigned right now. Will assign something if any of them open up.

Sure. 😓

rohitnandi12 commented 1 year ago

@JayVivarekar You can assign the files to someone else. Due to other commitments, I will not be able to complete this task.

sambhavgupta0705 commented 1 year ago

@JayVivarekar can you please assign those files to me?

seanlip commented 1 year ago

@nithinrdy this isn't actually completed, any reason you closed it?

nithinrdy commented 1 year ago

@nithinrdy this isn't actually completed, any reason you closed it?

My bad, that was by mistake.

JayVivarekar commented 1 year ago

@NPDebs @gnurris @sambhavgupta0705 Assigned one file to each of you.

sk-2809 commented 1 year ago

Hello @JayVivarekar @vojtechjelinek I want to work on this issue. Could you please assign me some task

johngitahi commented 1 year ago

Hello @JayVivarekar I'd like to work on this issue, please assign me some tasks.

JayVivarekar commented 1 year ago

@sk-2809 All files are assigned right now. Will assign something if any of them open up.

balogun14 commented 1 year ago

I’ve been on this for days the Icon is not showing I don’t know what to change

Emmanuel-Lud commented 1 year ago

Hello @JayVivarekar @vojtechjelinek. I'd like to work on these issues. oppia/core/templates/base-components/no-script.template.html oppia/core/templates/components/checkpoint-celebration-modal/checkpoint-celebration-modal.component.html oppia/core/templates/components/question-directives/question-misconception-selector/question-misconception-selector.component.html

ujjwalban commented 1 year ago

Hi , can you assign me any three for now, as I would like contribute in this. @JayVivarekar

JayVivarekar commented 1 year ago

@balogun14 Can you specify more about the issue you are facing?

balogun14 commented 1 year ago

@JayVivarekar the Icon is not showing just seeing a Unicode symbol no icon

allisongoldstein commented 1 year ago

I'd like to work on this if any of the files become available.

Sean-Zhong commented 1 year ago

Hello @JayVivarekar and @vojtechjelinek , I would like to work on one of the files if possible.

richard-johansson commented 1 year ago

Hello @JayVivarekar and @vojtechjelinek! I'd like to give a go with one of these

JayVivarekar commented 1 year ago

@johngitahi @Emmanuel-Lud @ujjwalban @allisongoldstein @Sean-Zhong @richard-johansson All files are assigned right now. Will assign something if any of them open up.

JayVivarekar commented 1 year ago

@anniemacdev @rishabhknowss @SubhashThenua @abhishek-sultaniya @kimchavsov @DecryptAG @amyra98 @ayushanand16 @AsmaKacem1 @Om-Aditya-Jain @akshit5565 @NPDebs @gnurris @sambhavgupta0705 @akshit5565 @Aacashh. Please reply if you are not working on the files assigned to you so that they can be re-assigned.

ayushanand16 commented 1 year ago

@anniemacdev @rishabhknowss @SubhashThenua @abhishek-sultaniya @kimchavsov @DecryptAG @amyra98 @ayushanand16 @AsmaKacem1 @Om-Aditya-Jain @akshit5565 @NPDebs @gnurris @sambhavgupta0705 @akshit5565 @Aacashh. Please reply if you are not working on the files assigned to you so that they can be re-assigned.

I am no longer working on the remaining files assigned to me as they are dead code as I have been told by the code owners of those files.

Thanks

SubhashThenua commented 1 year ago

@JayVivarekar I am no longer working on this as I have completed my all the assigned files. If any file is left please unassign me. As I am working on Lace Quality high priority issues.

Thanks

Om-Aditya-Jain commented 1 year ago

@anniemacdev @rishabhknowss @SubhashThenua @abhishek-sultaniya @kimchavsov @DecryptAG @amyra98 @ayushanand16 @AsmaKacem1 @Om-Aditya-Jain @akshit5565 @NPDebs @gnurris @sambhavgupta0705 @akshit5565 @Aacashh. Please reply if you are not working on the files assigned to you so that they can be re-assigned.

@JayVivarekar I am no longer working on this issue. Please unassign me.

JayVivarekar commented 1 year ago

@sk-2809 @johngitahi @Emmanuel-Lud @ujjwalban Assigned one file to each of you.

kashishbhandula commented 1 year ago

Hi, @JayVivarekar can you please assign me one of the files!!.

sahiljoster32 commented 1 year ago

Hi @kashishbhandula, I have assigned you 3 files!

KaifShakeel76 commented 1 year ago

Hey.! I would like to work on these issues and complete them asap. Thank you

josieecook commented 1 year ago

@JayVivarekar Could you assign me one of the files?

852hamza commented 1 year ago

@JayVivarekar can you assign . i want to work on it

(oppia/core/templates/base-components/no-script.template.html) / (oppia/core/templates/components/question-directives/questions-list/questions-list.component.html )

vcvedika commented 1 year ago

@JayVivarekar Could you please assign me one of the files.

GarvitSinghal47 commented 1 year ago

@JayVivarekar Could you please assign me one of the files.

852hamza commented 1 year ago

@JayVivarekar (https://github.com/oppia/oppia/issues/15968#issuecomment-1344378864)

shaliniiii04 commented 1 year ago

Hey!! @vojtechjelinek @JayVivarekar . I am interested to contribute. Please assign me some task. Thank u

JayVivarekar commented 1 year ago

@JayVivarekar can you assign . i want to work on it

(oppia/core/templates/base-components/no-script.template.html) / (oppia/core/templates/components/question-directives/questions-list/questions-list.component.html )

@852hamza I have assigned you the second file

JayVivarekar commented 1 year ago

@allisongoldstein @richard-johansson @KaifShakeel76 @josieecook @vcvedika @GarvitSinghal47 @shaliniiii04 Asigned one file to each of you.

852hamza commented 1 year ago

@JayVivarekar can you assign . i want to work on it

(oppia/core/templates/base-components/no-script.template.html) / (oppia/core/templates/components/question-directives/questions-list/questions-list.component.html )

@852hamza I have assigned you the second file

@JayVivarekar Thank you I can work on it

852hamza commented 1 year ago

@JayVivarekar hi can you check my pull request

852hamza commented 1 year ago

i also solve this issue can you assign me

@JayVivarekar

KaifShakeel76 commented 1 year ago

direnv: error .envrc file not found This message is showing while i am trying to install oppia into my ubuntu system with all the steps following step-by-step instructions that are written @https://github.com/oppia/oppia/wiki/Installing-Oppia-%28Linux%3B-Python-3%29. If someone can help me, that would be greatly appreciated.

On Sat, Dec 17, 2022 at 10:22 AM Jay Vivarekar @.***> wrote:

The Oppia frontend uses two icon families namely Font Awesome and Material icons. It has been decided to do away with Material icons throughout the frontend code and use only Font Awesome icons. This issue requires you to replace the material icons with corresponding (or similar) Font Awesome icons. Getting Assigned.

Select around three files from the list given below and ask @JayVivarekar https://github.com/JayVivarekar or @vojtechjelinek https://github.com/vojtechjelinek to assign them to you. Instructions

  1. After a file is assigned to you, go through that file and find the occurrences of Material Icons in them.
  2. For a given occurrence, run the Oppia server locally and try to find the icon in the frontend.
  3. Replace the icon to the closest Font Awesome 5 icon you can find. You can search through all available icons here https://fontawesome.com/v5/search. Make sure to use only "Free" icons.
  4. If you are confused regarding which icon to use, feel free to ask @JayVivarekar https://github.com/JayVivarekar or @vojtechjelinek https://github.com/vojtechjelinek.
  5. Make sure to screenshot all the icons that you've replaced (before and after) and put these screenshots in the PR description.

NOTE : You might need to modify the relevant CSS files to get correct appearance of the replaced icon. PR for reference

15926 https://github.com/oppia/oppia/pull/15926

List of files with material icons

— Reply to this email directly, view it on GitHub https://github.com/oppia/oppia/issues/15968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWVPWG6CY2VUQJVSTT7JHBDWNVBJ5ANCNFSM6AAAAAAQBBVNEY . You are receiving this because you were mentioned.Message ID: @.***>

852hamza commented 1 year ago

create .envrc in the oppia directry in this file save this content use python 3.2

@KaifShakeel76

852hamza commented 1 year ago

@JayVivarekar

852hamza commented 1 year ago

@JayVivarekar