Acceptance Testing - covering all the Creator's and Contributor's CUJs.

[Shivkant-Chauhan]

Describe the bug

In order to verify that key user journeys do not break, the Oppia development team is implementing Acceptance Testing for the develop branch. This means that, on every commit, all key requirements are verified through a set of acceptance tests that check that each type of end user can do the things they expect to do on the site.

The aim of this issue is to build up a set of such tests for all the CUJs that creators and contributors experience on Oppia. Please see the instructions below for how to claim a task in this issue. (Feel free to contact @oppia/acceptance-test-reviewers if you have any doubts!)

# Instructions

1. Carefully read the “How to write Acceptance Tests” wiki page.
2. Select 1 or more “package” (of 1-2 user stories each) from the list below, and get yourself assigned to them from @oppia/acceptance-test-reviewers
3. After the user stories are assigned to you, go to the user file for the tests inside core/tests/puppeteer-acceptance-tests/spec/<user-type>tests.spec.js
4. Start writing the assigned user stories based on the Testing Spreadsheet. Each user story in the spreadsheet should be covered within 1 it block, and all the test steps and expectations should match the expected behavior. You might also need to write utility functions, similar to the existing examples below.
5. After you have written the tests, make sure they run fine on your local machine before submitting your PR. If this is your first time writing acceptance tests, we suggest writing the tests for one user story and verifying that it runs fine before adding the rest of the tests to your PR.
6. In case of any confusion or for PR reviews, feel free to ask @oppia/acceptance-test-reviewers
7. After getting assigned to a package(containing 2-3 user stories), your inactivity/no communication for more than 7 days may lead to getting unassigned from the task assigned.

For reference: You can see an example set of acceptance tests for “blog admin”/”blog editor” here. Please follow a similar format and file naming convention for the tests that you write:

• Top-level tests:
  • core/tests/puppeteer-acceptance-tests/spec/blog-admin-tests/
  • core/tests/puppeteer-acceptance-tests/spec/blog-editor-tests/
• User-utilities: core/tests/puppeteer-acceptance-tests/utilities/user/blog-post-editor.ts
• User factory: core/tests/puppeteer-acceptance-tests/utilities/common/user-factory.ts

List of user stories (arranged by user type)

(serial numbers same as testing spreadsheet row number for each user type)

Blog Editor

2.1 Users can create and delete draft blog posts 2.2 Users unable to publish an empty blog-post, can publish a blog post (upload thumbnail image, add tags, add title and body) and delete that published blog post from the Published Tab.

Exploration Creator

• [ ] 3- Users can record voiceovers in different languages, upload voiceovers for their question explorations in different languages, and monitor progress…………. 4- Users can create questions from the exploration, add questions from the exploration

• [x] 5- Users can see history in the exploration editor, can check the latest version with notes, user, and date, and compare any two versions from ………… -- @Akhilesh-max (PR: https://github.com/oppia/oppia/pull/19828) 6- User can preview the exploration, and can start the questions from the beginning -- @Akhilesh-max

• [ ] 7- User can navigate to the Feedback Tab: The user can access the Feedback Tab in the Exploration Editor and view all the feedback …………. 8- User can ask for "Help" for the editor's exploration, take a tour of the editor's exploration, visit the help centerTake the translator tour

• [x] 9- User can do the Basic setting: Title, Goal, Add a category, Language, Name of the first card, Tags, Advance features, Roles, Voice artist, Permissions …….. -- @rahat2134 (PR: https://github.com/oppia/oppia/pull/19780) 10- User can Publish the latest changes, User can draft the latest changes -- @rahat2134

• [ ] 11- User can use all the interactions.

• [ ] 13- User can use all RTE components.

• [ ] 12- User can publish an exploration with an interaction. 14- User can view and make changes to a previously-published exploration 15- User can see statistics about number of views, ratings, etc. in the creator dashboard

Voiceovers

• [ ] Voiceover artist Voiceover artist can add audio recordings to any exploration

Contributor Dashboard

• [ ] Translation submitter Tracking bug: https://github.com/oppia/oppia/issues/18892 1.1 User can select a topic and a language, and then successfully submit a translation for that lesson card in that language. 1.2 User can see stats, badges and generate a certificate based on stats

• [ ] Translation Reviewer 2.1 User can view the translated lessons in a topic, review the cards in the lesson and accept the translation in each card 2.2 User can see stats, badges and generate a certificate based on stats

• [ ] Practice Question Submitter Tracking bug: https://github.com/oppia/oppia/issues/18894 4.1 Users can suggest questions by selecting the difficulty level of a lesson in a Topic 4.2 Users can suggest questions by selecting difficulty level as Hard to a lesson in a Topic 4.3 User can see stats, badges and generate a certificate based on stats

• [ ] Practice Question Reviewer Tracking bug: https://github.com/oppia/oppia/issues/18896 5.1 Users can review a question on a topic and Accept it 5.2 Users can review a question in a topic and Reject it 5.3 User can see stats, badges and generate a certificate based on stats

[seanlip]

@Akhilesh-max Please create a draft PR showing a part of the user journey. If it looks good, we can assign you so that you can complete the rest of it. Thanks!

[rahat2134]

@seanlip I am also working on 9 and 10th user journey , will update you with a draft PR once completed.

[rahat2134]

@seanlip please assign me the 9th and 10th user journeys in the Exploration Creator section. I just need to make some minor changes in the PR, otherwise it's almost complete. Some flakes need to be addressed. I have raised a PR #19780 . (You can start reviewing it if possible.)

[rahat2134]

@seanlip till PR #19780 for user journey 9 and 10 is getting reviews from reviewers, can you assign me user journey 7 and 8 in exploration creator. Will try to do that asap .(Started working on this).

[Akhilesh-max]

@seanlip, I’ve initiated the PR draft for the following CUJs:

5- Users have the ability to view history in the exploration editor, inspect the latest version with its notes, user, and date, and compare any two versions. 6- Users can preview the exploration and initiate the questions from the start.

While the work is almost complete, it’s occasionally failing or, to be precise, it’s a bit flaky. However, I anticipate that these issues will be resolved in the next couple of days. I would appreciate your initial round of reviews. (please assign me as well)

Thanks.

[rahat2134]

@seanlip till PR #19780 for user journey 9 and 10 is getting reviews from reviewers, can you assign me user journey 7 and 8 in exploration creator. Will try to do that asap .(Started working on this).

although i can do it and i had started doing this but since there are already 2 pr opened for exploration-editor, it will be quite difficult to manage merge conflict and complexities. Hence what I think I should do **3- As a learner I should be able to play an embedded lesson** until those 2 pr get merged. Thank You. @seanlip what you think? Although you can assign me both, the above-mentioned one will be done as soon as possible, and the exploration-editor one will be done afterwards.

[seanlip]

@rahat2134 Please take just one acceptance test issue at a time. Merge it before taking the next one. It is important to ensure you can do quality PRs, more is not necessarily better.

@Akhilesh-max I've assigned you. I am not sure I have time to review but perhaps you can get some feedback from @oppia/acceptance-test-reviewers.

[jnvtnguyen]

@seanlip Can I pick up one (have no preference)

[seanlip]

@jnvtnguyen Added you to the first exploration editor one. Thanks!

[jnvtnguyen]

@seanlip BTW doesn't this overlap with other PRs (exploration editor utils, etc.)

[seanlip]

@jnvtnguyen It might -- sorry, I haven't looked in detail, just added you to the first one on the list. Perhaps pick one that doesn't?

[jnvtnguyen]

Topic manager 3 4 is fine then.

[seanlip]

Thanks! Updated.

Just as a note: might be worth seeing the current ongoing review on https://github.com/oppia/oppia/pull/19780 to get a sense of coding conventions.

[jnvtnguyen]

@seanlip As clarification when the story says to login as an admin account and create topics should the admin be created through the existing superAdmin and assigned a role of curric admin or a new utils file?

[seanlip]

@jnvtnguyen I don't understand your question, sorry. Could you please elaborate?

[jnvtnguyen]

Ah sorry, right now each user represents a "role" but inside the google sheets it asks to create a super admin user and create topics (which here I suppose means to create a curriculum admin, which I did). Also is @agallop currently working on the curriculum admin because topic manager has overlaps with curriculum admin like I said since you need a curriculum admin to setup for the topic manager.

[seanlip]

@jnvtnguyen I think curriculum admin is the right thing to do, thanks.

And I'm not sure @agallop is actually working on curriculum admin -- I'll deassign him. Given this, do you want to work on topic manager or curriculum admin, @jnvtnguyen?

[jnvtnguyen]

@seanlip You can unassign me, I will try to work on #18268 and #17416 first.

[Vir-8]

Hey @seanlip, can I pick one up if possible?

[seanlip]

@Vir-8 Sure. Which one do you want?

[Vir-8]

@seanlip Any works. I am new to acceptance testing so apologies - I'm not sure, but preferably something not too complex for starting out

[seanlip]

@Vir-8 OK, thanks, I gave you one of the curriculum admin ones.

[AFZL210]

@seanlip I would like to give this a try. Can you assign me the classroom creation part of the curriculum admin?

[seanlip]

@AFZL210 Done, thanks.

[hrshkshri]

Hey @seanlip Can I get assigned to one, maybe an easy one first : )

[seanlip]

@hrshkshri Feel free to pick one that you like and self-assign, thanks.

[AFZL210]

@seanlip just a question. In the setup section of the testing spreadsheet for curriculum admin (classroom journey), it's creating a new topic manually.

And for that, we already have a separate journey, so should I just use the admin panel function to create a topic?

[seanlip]

@AFZL210 No, admin Activities panel is not functional in prod mode. Try to reuse functionality from that other journey for now.

[AFZL210]

@AFZL210 No, admin Activities panel is not functional in prod mode. Try to reuse functionality from that other journey for now.

Ok, I guess the classroom journey should be implemented when this PR is merged, as there are many overlapping functions.

[AFZL210]

@seanlip as Vir is working on the curriculum PR, which I guess will take some time, in the meantime, can I work on logged-in learner cases 3 & 4?

[seanlip]

@AFZL210 Yup, sure thing, I switched your assignment, thanks for the ping.

[rahat2134]

@seanlip If it seems appropriate, please update the issue description with the new CUJs that have been added to the spreadsheet. For eg. -> CUJ 11,12,13 in exploration creator.

[seanlip]

@rahat2134 Done, thanks. Please let me know if there are any more gaps.

[rahat2134]

@seanlip Practice Question Reviewer has been implemented. Please mark it as done. Also, there is 3rd CUJ in Practice Question Reviewer and others also -> User can see stats, badges and generate a certificate based on stats which is not mentioned here.

Also, is each CUJ of blog editor implemented, as no checkbox for blog editor here?

[pritam2317]

Hi @seanlip can you assign me to the curiculum admin (2) ?

[Nik-09]

Hi @seanlip can you assign me to the curiculum admin (2) ?

Done

[Akhilesh-max]

The list of journeys mentioned above is not exhaustive. I will continue adding the creator’s and contributor’s CUJs that need to be documented. @rahat2134, would you like to help me with this? Perhaps you would be having a list of creator’s and contributor’s CUJs?