oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.62k stars 3.78k forks source link

[BUG]: Topics and Skills Dashboard instructs curriculum admin to add the topic to the classroom from the Admin page #20177

Closed StephenYu2018 closed 3 weeks ago

StephenYu2018 commented 3 weeks ago

Describe the bug

On the Topics and Skills Dashboard, when curriculum admins hover over a published topic that is not assigned to a classroom, they expect a tooltip that instructs them the page where topics are added to classrooms. While they should be instructed to go to the more recent Classroom Admin page, they are instead instructed to go to the outdated Admin page Config tab.

URL of the page where the issue is observed.

/topic-and-skills-dashboard

Steps To Reproduce

  1. Go to the Admin page Roles tab.
  2. Assign the "Curriculum Admin" role to yourself.
  3. Go to the Admin page Activities tab.
  4. Click "Load Data" under "Load dummy new structures data".
  5. Go to the Topics and Skills Dashboard page at URL /topics-and-skills-dashboard. Wait for the topics to load.
  6. Hover over "No Classroom Assigned" under the topic's name. Wait for a tooltip to appear.
  7. Read the tooltip message. It's instructing curriculum admins to add the topic to a classroom from the "admin page".

Expected Behavior

The tooltip message should instruct curriculum admins to add the topic to a classroom from the "classroom admin page".

Screenshots/Videos

tooltip-still-refers-to-admin-page

What device are you using?

Desktop

Operating System

Linux

What browsers are you seeing the problem on?

Chrome

Browser version

122.0.6261.128

Additional context

No response

Tips for developers

Before addressing the bug, please identify which PR caused the issue (you can follow the steps here). If you identify the PR, comment on the issue with a link to it. If not, mention the commit hash of the oldest commit you saw the bug on (and the month and year it was made in).

Then, please leave a comment with details of the approach that you plan to take to fix the issue (see example).

Note: If this is your first Oppia issue, please make sure to follow our guidelines for choosing an issue and setting things up. You will also need to show a demo of the fix working correctly on your local machine. Thanks!

github-actions[bot] commented 3 weeks ago

Hi @AFZL210, thanks for proposing this as a good first issue. I am removing the label for now and looping in @DubeySandeep to approve the label. It will be added back if approved. Thanks!

rahat2134 commented 3 weeks ago
Screenshot 2024-04-18 at 4 27 48 PM Screenshot 2024-04-18 at 4 28 12 PM
rahat2134 commented 3 weeks ago

This issue is solved by #20181