Fix #16413: E2E passing even after a console error.

jnvtnguyen commented 3 weeks ago

Overview

This PR fixes #16413.
This PR does the following: This PR fixes the checkForConsoleErrors functionality in the E2E tests by changing the threshold filter which was broken due to the migration from protractor.
(For bug-fixing PRs only) The original bug occurred because: The migration from protractor overlooked the change in console error thresholding, resulting in all console errors not being caught.

Essential Checklist

Please follow the instructions for making a code change.

[x] I have linked the issue that this PR fixes in the "Development" section of the sidebar.
[x] I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
[ ] I have written tests for my code.
[x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
[x] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot[bot] commented 3 weeks ago

Hi @jnvtnguyen, can you complete the following:

The body of this PR is missing the required description, please update the body with a description of what this PR does. Thanks!

oppiabot[bot] commented 3 weeks ago

Hi @jnvtnguyen please assign the required reviewer(s) for this PR. Thanks!

jnvtnguyen commented 2 weeks ago

@DubeySandeep PTAL, still have one console error to catalog, though it should show that checkForConsoleErrors is working now.

oppiabot[bot] commented 1 week ago

Hi @jnvtnguyen, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppia / oppia