Closed amyyeung17 closed 1 day ago
Assigning @nikitaevg for the first pass review of this PR. Thanks!
Unassigning @nikitaevg since the review is done.
Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!
Please try to make concise PRs, I'm not sure I follow why you add changes in the pages/learner-dashboard-page directory. If they are not related to the main change in the PR please don't add them.
Ah sorry, I'll keep the first part in mind. Regarding the changes in pages/learner-dashboard-page, explorations and collections were only retrieved when a user manually clicks the Community Lessons button in the sidebar. I had to move some of the code to use the data in the home tab.
Unassigning @nikitaevg since the review is done.
Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!
Unassigning @nikitaevg since the review is done.
Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!
Unassigning @nikitaevg since the review is done.
Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!
Unassigning @nikitaevg since the review is done.
Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!
Should this work with rtl languages? If so, please confirm that the current solution works with the Arabic language, or fix it in the next PR.
Apart from that, this might be the last portion of comments for this PR
@nikitaevg It works for the most part. There's just some minor adjustments that I'll handle in a different PR. Might also need to file an issue for the console error that appeared when switching over to Arabic.
https://github.com/oppia/oppia/assets/28910543/3ca6b330-a7d6-43a9-8cc8-ed9a7c685996
Unassigning @nikitaevg since the review is done.
Hi @amyyeung17, it looks like some changes were requested on this pull request by @nikitaevg. PTAL. Thanks!
Unassigning @nikitaevg since they have already approved the PR.
Unassigning @DubeySandeep since they have already approved the PR.
Hi @amyyeung17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!
Overview
This PR addresses part of the 2nd breakpoint of https://github.com/oppia/oppia/issues/18384, adding a new reusable card component.
Includes 3 new files:
This reusable card component essentially consolidates these files in summary-tile beginning with:
Additional notes:
Essential Checklist
Please follow the instructions for making a code change.
Proof that changes are correct
https://github.com/oppia/oppia/assets/28910543/026dd92b-8e54-40e1-9a46-8445a00a73f2