oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.63k stars 3.78k forks source link

Implements part of #17712 : Acceptance tests for CUJs in the history tab of the exploration creator. #20191

Open Akhilesh-max opened 3 weeks ago

Akhilesh-max commented 3 weeks ago

Overview

  1. This PR fixes or fixes part of #17712
  2. This PR does the following: Adds the acceptance test for the following CUJs in exploration editor section.

    (serial numbers same as testing spreadsheet row number for each user type)

Essential Checklist

Please follow the instructions for making a code change.

PR Pointers

oppiabot[bot] commented 3 weeks ago

Hi @Akhilesh-max, can you complete the following:

  1. The body of this PR is missing the proof that changes are correct section, please update it to include the section. Thanks!
oppiabot[bot] commented 3 weeks ago

Hi @Akhilesh-max please assign the required reviewer(s) for this PR. Thanks!

oppiabot[bot] commented 3 weeks ago

Hi @Akhilesh-max. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

Akhilesh-max commented 1 week ago

@StephenYu2018 PTAL

oppiabot[bot] commented 1 week ago

Unassigning @Akhilesh-max since a re-review was requested. @Akhilesh-max, please make sure you have addressed all review comments. Thanks!

oppiabot[bot] commented 1 week ago

Unassigning @StephenYu2018 since the review is done.

oppiabot[bot] commented 1 week ago

Hi @Akhilesh-max, it looks like some changes were requested on this pull request by @StephenYu2018. PTAL. Thanks!

Akhilesh-max commented 1 week ago

Thanks @StephenYu2018. Addressed all your comments, I am stuck somewhere, as well. Have left a comment.

oppiabot[bot] commented 1 week ago

Assigning @nikitaevg, @U8NWXD for code owner reviews. Thanks!

oppiabot[bot] commented 1 week ago

Unassigning @nikitaevg since they have already approved the PR.

oppiabot[bot] commented 1 week ago

Hi @Akhilesh-max, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

oppiabot[bot] commented 3 days ago

Hi @Akhilesh-max. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!