Fix part of issue #18422: remove/replace deprecated prerequisite skillids when a skill is deleted/merged

sworth45 commented 3 weeks ago

Overview

This PR fixes part of #18422.
This PR does the following: This PR is designed to stop skill's prerequisite skill lists from becoming outdated after a member of the list is deleted. Whenever a skill is deleted/merged, it updates any skills which have it as a prerequisite by deleting/swapping it.
(For bug-fixing PRs only) The original bug occurred because: The original bug occured because there was no connection between a skill and it's id on another skill's prerequisite list.

Essential Checklist

Please follow the instructions for making a code change.

[x] I have linked the issue that this PR fixes in the "Development" section of the sidebar.
[x] I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
[x] I have written tests for my code.
[x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
[x] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Proof of changes on desktop with slow/throttled network

Before: https://drive.google.com/file/d/12donQW5sqU5vcr4RNC10sYuALoU7a6cp/view

After: https://drive.google.com/file/d/1fgqF0xmgiVPbzZtd6zVutdKOUQDWO6pS/view (Both running locally)

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot[bot] commented 3 weeks ago

Hi @sworth45 please assign the required reviewer(s) for this PR. Thanks!

oppiabot[bot] commented 1 week ago

Hi @sworth45, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

oppia / oppia