oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.62k stars 3.78k forks source link

Implement part of #17712 : Acceptance tests for Exploration Creator Section(CUJ 10). #20203

Open rahat2134 opened 2 weeks ago

rahat2134 commented 2 weeks ago

Overview

  1. This PR fixes part of #17712 .
  2. This PR does the following: Adds acceptance test for exploration editor section. Points: 10- User can Publish the latest changes, User can draft the latest changes)

    Essential Checklist

Proof that changes are correct

Screenshot 2024-04-23 at 10 20 24 PM

PR Pointers

oppiabot[bot] commented 2 weeks ago

Hi @rahat2134 please assign the required reviewer(s) for this PR. Thanks!

rahat2134 commented 2 weeks ago

@seanlip PTAL. Although this has already been reviewed by you. But for the sake of convenience take a look again. Modification - • Add a wait for autosave pop to be visible and then hidden (for desktop) when we make any change. • Have to add external wait For of 2 seconds because in mobile viewport we don't have Auto saving.... pop up. There is no UI change. So, At last, I have to use waitForTimeout

oppiabot[bot] commented 2 weeks ago

Hi @rahat2134, it looks like some changes were requested on this pull request by @StephenYu2018. PTAL. Thanks!

rahat2134 commented 2 weeks ago

@StephenYu2018 PTAL

oppiabot[bot] commented 2 weeks ago

Unassigning @StephenYu2018 since they have already approved the PR.

oppiabot[bot] commented 2 weeks ago

Hi @rahat2134. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

rahat2134 commented 2 weeks ago

Changing PR to draft PR till #20231 got merge