Fix #19816 Change where headerText and subheaderText value are set and fix their display on frontend

Sepremo commented 2 weeks ago

Overview

This PR fixes #19816.
This PR does the following: Relocated the updates for the headerText and subheaderText values from the Chapter Editor component (story-node-editor.component.ts) to the component responsible for the navigation of the Story Editor (in story-editor-navigation.service.ts), like it is done for the updates of SubTopic values in the component for routing of the Topic Editor (in topic-editor-routing.service.ts)
The original bug occurred because: The headerText (along with subheaderText) property undergoes updates after Angular's change detection cycle has concluded. This behavior stems from the component managing the new Chapter Editor Tab. The issue arises because it alters a bound value (as bound in the top-navigation-bar.component.html) within a new Tab (Chapter Editor), albeit within the same page (Story Editor). This error came from the code migration in #17968.

Essential Checklist

Please follow the instructions for making a code change.

[x] I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
[x] I have written tests for my code.
[x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
[x] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).
[x] The linter/Karma presubmit checks pass on my local machine, and my PR follows the coding style guide).
[x] "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)

Proof that changes are correct

https://github.com/oppia/oppia/assets/12527288/2cba4632-b20e-485a-b7dd-5db2740edf4e

After

oppiabot[bot] commented 2 weeks ago

Assigning @Lawful2002 for the first pass review of this PR. Thanks!

Sepremo commented 2 weeks ago

@seanlip PTAL

Ash-2k3 commented 4 days ago

Hi @Sepremo, just wanted to check, if there's any update on this ?

Sepremo commented 16 hours ago

Hi @Ash-2k3, sorry, I've been a bit busy but I am going to see if it's easy to fix the other similar issues. In the meantime I'll add the changes to fix navigateToChapterEditor.

oppia / oppia