oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.63k stars 3.78k forks source link

Fix#20125: Convert string to regex. #20220

Closed rahat2134 closed 2 weeks ago

rahat2134 commented 2 weeks ago

Overview

  1. This PR fixes or fixes part of #20125
  2. This PR does the following: There was an error in console occuring. When using Puppeteer to preview documents via Google Docs Viewer in Node.js, the browser throws an error. Despite the URL working well in a browser environment, attempting to access it through Puppeteer results in an error. Set that error to ignore because it was from external factors and breaking the tests.

Essential Checklist

Please follow the instructions for making a code change.

Proof that changes are correct

Screenshot 2024-04-24 at 11 06 57 PM

PR Pointers

oppiabot[bot] commented 2 weeks ago

Assigning @StephenYu2018 for the first pass review of this PR. Thanks!

rahat2134 commented 2 weeks ago

Don't know why mypy checks are failing. I think there is something due to current branch which I restored. Opening new PR with new branch. This branch was deleted from my local machine and I think that is causing error.