Fix#20125: Convert string to regex.

rahat2134 commented 2 weeks ago

Overview

This PR fixes or fixes part of #20125
This PR does the following: There was an error in console occuring. When using Puppeteer to preview documents via Google Docs Viewer in Node.js, the browser throws an error. Despite the URL working well in a browser environment, attempting to access it through Puppeteer results in an error. Set that error to ignore because it was from external factors and breaking the tests.

Essential Checklist

Please follow the instructions for making a code change.

[X] I have linked the issue that this PR fixes in the "Development" section of the sidebar.
[X] I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
[ ] I have written tests for my code.
[X] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
[X] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot[bot] commented 2 weeks ago

Assigning @StephenYu2018 for the first pass review of this PR. Thanks!

oppiabot[bot] commented 2 weeks ago

Unassigning @StephenYu2018 since they have already approved the PR.

oppiabot[bot] commented 2 weeks ago

Hi @rahat2134, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

rahat2134 commented 2 weeks ago

@seanlip Its ready to merge. PTAL.

oppiabot[bot] commented 2 weeks ago

Unassigning @rahat2134 since a re-review was requested. @rahat2134, please make sure you have addressed all review comments. Thanks!

oppia / oppia