Fix #19664 and part of #15948: Use projection queries to fetch reviewable translation suggestion target IDs

StephenYu2018 commented 2 weeks ago

Overview

This PR fixes #19664 and fixes part of #15948.

This PR does the following:

Add GeneralSuggestionModel.get_in_review_translation_suggestion_target_ids method that runs a projection query to fetch only the target_id
- Added backend test "gets target ids of translation suggestions in review"
Add suggestion_services.get_reviewable_translation_suggestion_target_ids method that calls the above datastore model method
- Added backend test "gets target ids of reviewable translation suggestions for user"
Change ReviewableOpportunitiesHandler._get_reviewable_exploration_opportunity_summaries method flow to call the above service-layer function. This reduces server response wait times as we're fetching only target_id instead of the entire model from datastore.

The purpose of these changes is to reduce server response wait times. These results can be found in this comment of mine.

Essential Checklist

Please follow the instructions for making a code change.

[x] I have linked the issue that this PR fixes in the "Development" section of the sidebar.
[x] I have checked the "Files Changed" tab and confirmed that the changes are what I want to make.
[x] I have written tests for my code.
[x] The PR title starts with "Fix #bugnum: " or "Fix part of #bugnum: ...", followed by a short, clear summary of the changes.
[x] I have assigned the correct reviewers to this PR (or will leave a comment with the phrase "@{{reviewer_username}} PTAL" if I can't assign them directly).

Proof that changes are correct

Before: issue-19664-proof-before

After: issue-19664-proof-after

Proof of changes on desktop with slow/throttled network

issue-19664-slow-proof

Proof of changes on mobile phone

issue-19664-mobile-proof

Proof of changes in Arabic language

issue-19664-arabic-proof

PR Pointers

Never force push! If you do, your PR will be closed.
To reply to reviewers, follow these instructions: https://github.com/oppia/oppia/wiki/Make-a-pull-request#step-5-address-review-comments-until-all-reviewers-approve
Some e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.
See the Code Owner's wiki page for what code owners will expect.

oppiabot[bot] commented 2 weeks ago

Hi @StephenYu2018 please assign the required reviewer(s) for this PR. Thanks!

oppiabot[bot] commented 2 weeks ago

Hi @StephenYu2018. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

seanlip commented 1 week ago

@kevintab95 @chris7716 PTAL for codeowners, thanks!

StephenYu2018 commented 1 week ago

@kevintab95 @chris7716 PTAL!

oppiabot[bot] commented 1 week ago

Unassigning @chris7716 since they have already approved the PR.

oppia / oppia