oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.63k stars 3.78k forks source link

Fix #19137: Shift rte-modal's save button to outside translation box in translation review modal(Contributor dashboard ) #20228

Closed Felix-Mauyon closed 2 weeks ago

Felix-Mauyon commented 2 weeks ago

Overview

  1. This PR fixes #19137
  2. The PR shifts rte-modal's save button to the outside of the translation box. This is to ensure that when users are in edit mode, they do not have to scroll down to save the changes for given translation while reviewing.

Essential Checklist

Proof that changes are correct

Before

Screenshot 2024-04-26 204831

After

Screenshot 2024-04-26 205059

oppiabot[bot] commented 2 weeks ago

Hi @Felix-Mauyon, can you complete the following:

  1. The body of this PR is missing the proof that changes are correct section, please update it to include the section. Thanks!
oppiabot[bot] commented 2 weeks ago

Assigning @StephenYu2018 for the first pass review of this PR. Thanks!

oppiabot[bot] commented 2 weeks ago

Hi @Felix-Mauyon, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

Felix-Mauyon commented 2 weeks ago

@seanlip Please can you merge the PR. All checks have been passed

seanlip commented 2 weeks ago

Done. Thanks and congratulations on your first contribution to Oppia, @Felix-Mauyon! :tada: