search

oppia / oppia

A free, online learning platform to make quality education accessible for all.
https://www.oppia.org
Apache License 2.0
5.73k stars 3.87k forks source link

[Flake]: test_html_file (scripts.linters.run_lint_checks_test.PreCommitLinterTests) #20796

Open Akhilesh-max opened 1 month ago

Akhilesh-max commented 1 month ago

CI Test Type

Backend

Stacktrace

======================================================================
FAIL: test_html_file (scripts.linters.run_lint_checks_test.PreCommitLinterTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/oppia/oppia/scripts/linters/run_lint_checks_test.py", line 321, in test_html_file
    self.assert_same_list_elements(
  File "/home/runner/work/oppia/oppia/core/tests/test_utils.py", line 4341, in assert_same_list_elements
    self.assertTrue(
AssertionError: False is not true

Additional Information

No response

Occurrences

https://github.com/oppia/oppia/actions/runs/10304887351/job/28524416233

Debugging document link

No response

Akhilesh-max commented 1 month ago

@jnvtnguyen PTAL.

jnvtnguyen commented 3 weeks ago

@Akhilesh-max I'll take a look, but haven't seen this flake show up again, have you?

Akhilesh-max commented 3 weeks ago

@jnvtnguyen true, haven't seen it after this.

seanlip commented 3 weeks ago

Hm, I suggest taking a quick look to see if there's any obvious cause. If not then we can perhaps close this, though at the very least we should probably add some logging to assert_same_list_elements to print out the list so that this is more easily debuggable next time it occurs -- what do you think?

Akhilesh-max commented 3 weeks ago

@seanlip Sure, I will add logging to the assert_same_list_elements method to print out the lists being compared when the assertion fails and close this issue by 26-27 Aug.

Thanks.