search

oppia / oppiabot

Helper bot for the Oppia code repository dev workflow.
Apache License 2.0
19 stars 68 forks source link

Oppiabot should be more proactive towards new contributors #166

Open vojtechjelinek opened 3 years ago

vojtechjelinek commented 3 years ago

For PR authors who are new users: when they respond to reviews, and fail to leave a top-level comment, Oppiabot should ping the author and ask them to either say they’re still working on this, or @-mention the person they want a review from.

nlok5923 commented 3 years ago

@vojtechjelinek please can you assign me this issue.

riyasingh1004 commented 3 years ago

@vojtechjelinek I would like to work on this issue.

riyasingh1004 commented 3 years ago

@vojtechjelinek I am a bit confused here. I was thinking of adding a welcome message when a user makes his first PR. If the user doesn't leave any comment on the PR then Oppiabot should ping them to request a review.??

vojtechjelinek commented 3 years ago

I think this is a bit more open-ended issue, basically, for new contributors, only the Oppiabot should make the process of their first PR as easy as possible. Meaning that the contributors should not be tucked on anything and if they are Oppiabot helps them get unstuck or calls someone for help.

seanlip commented 3 years ago

@riyasingh1004 There is no need to leave a welcome message when a user makes their first PR. We don't want to incentivize spammy PRs. It may be fine to leave a message on "first PR merge" though (although it might be better if an actual human does that).

@vojtechjelinek please could you lay out the requirements clearly for this issue? It should not be left open-ended as per your last comment.

seanlip commented 3 years ago

Next step: onboarding team to analyze first-time PRs, make a list of common issues, and suggest fixes to Oppiabot.

DubeySandeep commented 3 years ago

Requirements:

  1. Ask one of the reviewers to approve the run build for the first-time contributors. [Maybe ask the same person who adds changelog label to the PRs]
  2. We need to find a way to help to assign reviewers to the PR if the author (new contributor) misses leaving top-level comment or a PTAL comment. i. Maybe the bot can send new-contributor-specific comments in the PR that we recommend new-contributors to follow on their PR have better contribution experience. [Discussing this with other teams, will update once we'll have a solution]