oppiliappan / statix

lints and suggestions for the nix programming language
https://git.peppe.rs/languages/statix/about
MIT License
552 stars 21 forks source link

Warn on a long pattern in top-level lambda #48

Closed viraptor closed 1 year ago

viraptor commented 2 years ago

When there are more than 6 arguments, suggest splitting into multiple lines.

oppiliappan commented 2 years ago

i would say this is a formatting preference, and should be handled by formatting tools, rather than a linter, cc'ing some contributors for their opinions

cc @antifuchs @chenrui333 @NobbZ

NobbZ commented 2 years ago

Yeah, for me this is clearly in the domain of a formatter.

viraptor commented 2 years ago

So my idea behind putting it in a linter is that there are two aspects to this issue:

SuperSandro2000 commented 2 years ago

i would say this is a formatting preference, and should be handled by formatting tools, rather than a linter, cc'ing some contributors for their opinions

Yeah, I don't think that is fitting, too.

ilkecan commented 1 year ago

The number of arguments should be configurable rather than hardcoding 6, if this is accepted.

oppiliappan commented 1 year ago

while i do appreciate the work gone into this PR, i don't think this patchset fits in statix. i am very sorry, but i am going to have to close this one. i am very glad to have your contributions in statix however @viraptor!