search

oppiliappan / statix

lints and suggestions for the nix programming language
https://git.peppe.rs/languages/statix/about
MIT License
557 stars 21 forks source link

Filter out invalid eta-reductions #5

Closed danth closed 2 years ago

danth commented 2 years ago

If the remaining expression after eta-reduction still contains the removed function argument, eta-reduction is not possible. Fixes #4.

oppiliappan commented 2 years ago

I amended the commit message a bit, seems like GitHub is unable to tell that this commit has been included in master.

danth commented 2 years ago

@nerdypepper I think GitHub will only pick it up if you use the merge/squash/rebase buttons on the pull request page, and edit the message there.

oppiliappan commented 2 years ago

Ah I see, sorry, I messed this one up.

danth commented 2 years ago

Before you push any new commits, it's possible to clean up:

  1. Revert master to c3cede18c9440d05385f0a7fd7ae2ef628ce74aa
  2. Re-open the pull request
  3. Merge through the website

You should also have permission to push to my branch if you need to change any files before merging.

oppiliappan commented 2 years ago

Awesome, thanks!