search

oppiliappan / statix

lints and suggestions for the nix programming language
https://git.peppe.rs/languages/statix/about
MIT License
552 stars 21 forks source link

[bin/src/config.rs:79] [self.ignore.as_slice(), extra_ignores].concat() = [] #59

Closed neunenak closed 1 year ago

neunenak commented 1 year ago

If I run statix check on a file or directory, it prints the output:

[bin/src/config.rs:79] [self.ignore.as_slice(), extra_ignores].concat() = []

and nothing else. Looking at that line of code, I can see it is using the dbg! macro to print some debug output that doesn't seem relevant to the end user.

It looks like this might be the expected output if there are no problems with a particular nix file, but it would be nice if there was some explicit acknowledgement that there was nothing wrong with the linted files, rather than just this debug print and exiting.

samhh commented 11 months ago

For anyone else landing here, this is still present in 0.5.6 in nixpkgs as there hasn't been a release since this was fixed.

oppiliappan commented 11 months ago

pushed a tag for 0.5.7 now, should be fixed :crossed_fingers:

samhh commented 11 months ago

FYI --version still says 0.5.6, probably sourced from here: https://github.com/nerdypepper/statix/blob/master/bin/Cargo.toml#L3

oppiliappan commented 11 months ago

nice find, i had this documented in docs/release.txt, and i still forgot haha. i dont want to delete the tag, i assum that raises issues for package maintainers, will release v0.5.8.